| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
| |
JSON, and then load it as a dictionary object. The script will take a set of parameters which will allow the caller to target a set of remoting apps and output a space delimited string containing the target property they are interested in. This output string will be used by other bash/python scripts in a future CL to make generating remoting apps simpler.
BUG=
Review URL: https://codereview.chromium.org/934253004
Cr-Commit-Position: refs/heads/master@{#316983}
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting's symbol dumper was hard-coded to work on 32-bit x86 only. Similar to
r184545 for Chrome, it is now updated to check the built product for what
architectures are present. It will dump Breakpad symbols for 32-bit x86,
x86_64, or both, as present.
The symbol dumper is moved from an action in a distinct 'none'-type target to
a postbuild in the correct target. There was no guarantee that the 'none'
target would ever be built (and thus that symbols would be dumped), since
nothing actually depended on this target. It is likely that whatever required
symbols, if anything, was just building the 'All' target. This is not good
practice. A postbuild on the correct target is the right way to dump these
symbols.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206360
Review URL: https://chromiumcodereview.appspot.com/17003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206477 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make remoting_me2me_host build properly for official Mac 64-bit builds.
>
> remoting's symbol dumper was hard-coded to work on 32-bit x86 only. Similar to
> r184545 for Chrome, it is now updated to check the built product for what
> architectures are present. It will dump Breakpad symbols for 32-bit x86,
> x86_64, or both, as present.
>
> The symbol dumper is moved from an action in a distinct 'none'-type target to
> a postbuild in the correct target. There was no guarantee that the 'none'
> target would ever be built (and thus that symbols would be dumped), since
> nothing actually depended on this target. It is likely that whatever required
> symbols, if anything, was just building the 'All' target. This is not good
> practice. A postbuild on the correct target is the right way to dump these
> symbols.
>
> Review URL: https://chromiumcodereview.appspot.com/17003003
TBR=mark@chromium.org
BUG=249648
Review URL: https://codereview.chromium.org/17060003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206376 0039d316-1c4b-4281-b951-d872f2087c98
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
remoting's symbol dumper was hard-coded to work on 32-bit x86 only. Similar to
r184545 for Chrome, it is now updated to check the built product for what
architectures are present. It will dump Breakpad symbols for 32-bit x86,
x86_64, or both, as present.
The symbol dumper is moved from an action in a distinct 'none'-type target to
a postbuild in the correct target. There was no guarantee that the 'none'
target would ever be built (and thus that symbols would be dumped), since
nothing actually depended on this target. It is likely that whatever required
symbols, if anything, was just building the 'All' target. This is not good
practice. A postbuild on the correct target is the right way to dump these
symbols.
Review URL: https://chromiumcodereview.appspot.com/17003003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
BUG=136579
TEST=Official build logs
Review URL: https://chromiumcodereview.appspot.com/11340058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172270 0039d316-1c4b-4281-b951-d872f2087c98
|
