| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
We no longer need to support shaped desktop, so the corresponding
code can be removed.
Review URL: https://codereview.chromium.org/1827043004
Cr-Commit-Position: refs/heads/master@{#383340}
|
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
Cr-Commit-Position: refs/heads/master@{#382939}
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#383105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1817573003/ )
Reason for revert:
Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds.
BUG= 597559
Original issue's description:
> Move ServiceUrls to remoting/host
>
> ServiceUrls was used only in one place in android client and it's
> not really useful there. Moved it to the host directory.
>
> TBR=rogerta@chromium.org
>
> Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
> Cr-Commit-Position: refs/heads/master@{#382939}
TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1830993002
Cr-Commit-Position: refs/heads/master@{#383060}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#382939}
|
|
|
|
|
|
|
|
| |
BUG=577954
Review URL: https://codereview.chromium.org/1800893002
Cr-Commit-Position: refs/heads/master@{#381520}
|
|
|
|
|
|
|
|
|
|
|
| |
Moved ClientAuthenticationConfig to a separate file and now it's used
in PairingClientAuthenticator.
BUG=593123
Review URL: https://codereview.chromium.org/1794433002
Cr-Commit-Position: refs/heads/master@{#380872}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
Cr-Commit-Position: refs/heads/master@{#380779}
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380831}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:40001 of https://codereview.chromium.org/1778023002/ )
Reason for revert:
Appears to be breaking compile on Linux and Mac:
https://build.chromium.org/p/chromium/builders/Linux/builds/72875
https://build.chromium.org/p/chromium/builders/Mac/builds/13060
Output:
FAILED: /b/build/slave/Linux/build/src/build/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ ... -c ../../remoting/test/chromoting_test_fixture.cc -o obj/remoting/test/chromoting_test_driver.chromoting_test_fixture.o
In file included from ../../remoting/test/chromoting_test_fixture.cc:14:
In file included from ../../remoting/test/test_chromoting_client.h:14:
In file included from ../../remoting/client/chromoting_client.h:19:
In file included from ../../remoting/protocol/negotiating_client_authenticator.h:15:
In file included from ../../remoting/protocol/negotiating_authenticator_base.h:16:
../../third_party/webrtc/libjingle/xmllite/xmlelement.h:17:10: fatal error: 'webrtc/libjingle/xmllite/qname.h' file not found
#include "webrtc/libjingle/xmllite/qname.h"
^
1 error generated.
ninja: build stopped: subcommand failed.
Original issue's description:
> Move NegotiatingClientAuthentication creation to ChromotingClient.
>
> For the new SPAKE2 authenticator we need to pass client_jid
> to the authenticator. This wasn't possible previously because
> NegotiatingClientAuthenticator was created before signaling is
> connected. Moved NegotiatingClientAuthentication creation to
> ChromotingClient.
>
> BUG=589698
>
> Committed: https://crrev.com/279bf7c76a3e0bfbbd28748d0d02fcead88f4436
> Cr-Commit-Position: refs/heads/master@{#380779}
TBR=jamiewalch@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589698
Review URL: https://codereview.chromium.org/1788943002
Cr-Commit-Position: refs/heads/master@{#380785}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For the new SPAKE2 authenticator we need to pass client_jid
to the authenticator. This wasn't possible previously because
NegotiatingClientAuthenticator was created before signaling is
connected. Moved NegotiatingClientAuthentication creation to
ChromotingClient.
BUG=589698
Review URL: https://codereview.chromium.org/1778023002
Cr-Commit-Position: refs/heads/master@{#380779}
|
|
|
|
|
|
|
|
|
| |
Callbacks are already used to fetch PIN. It doesn't make sense to
use a different style to fetch third-party tokens.
Review URL: https://codereview.chromium.org/1774113005
Cr-Commit-Position: refs/heads/master@{#380316}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously AuthenticationMethod type was used in many places. Removed
all dependencies on it except from NegotiatingAuthenticator classes.
AuthenticationMethod has been moved to
NegotiatingAuthenticatorBase::Method.
Also includes the following cleanups:
- removed old authentication functions from auth_util.cc which were
no longer needed.
- Remove HashFunction enum as it wasn't useful.
BUG=589698
Review URL: https://codereview.chromium.org/1768383004
Cr-Commit-Position: refs/heads/master@{#380078}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1 Previously AuthenticationMethod was a class. Replaced
it with a simple enum.
2 Removed SharedSecretHash struct and simplified the code
that passes around PIN hash.
3 If the host config contains PIN in plain text then now
the host hashes it instead of using spake2_plain
authenticator method. This means that spake2_hmac is
always used for Me2Me even when the PIN is not hashed
in the config.
This change will make it easier to add new authentication
methods.
BUG=589698
Review URL: https://codereview.chromium.org/1755273003
Cr-Commit-Position: refs/heads/master@{#379365}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds out of line copy constructors for classes that our
clang-plugin considers heavy. This is an effort to enable copy
constructor checks by default.
BUG=436357
R=garykac@chromium.org, dcheng@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1736633002
Cr-Commit-Position: refs/heads/master@{#377988}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously IpcVideoFrameCapturer was called on the capturer thread,
while all IPC messages are sent and received on the network thread. Now
DesktopEnvironment implementations are responsible for creation of
DesktopCapturerProxy and MouseCursorMonitorProxy if necessary. This
allows to avoid capture thread on windows in the network process.
Also cleaned up unnecessary references to various task runners from
ChromotingHost and ClientSession.
BUG=458437
Review URL: https://codereview.chromium.org/1673723002
Cr-Commit-Position: refs/heads/master@{#375412}
|
|
|
|
|
|
|
|
|
| |
webrtc::DesktopCapturer::Callback::CreateSharedMemory() has been
deprecated and webrtc::SharedMemoryFactory should be used instead now.
Review URL: https://codereview.chromium.org/1690853002
Cr-Commit-Position: refs/heads/master@{#375224}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PepperPortAllocator and ChromiumPortAllocator were different only in
how they were sending HTTP requests to allocate relay session. They were
using pp::URLLoader and net::URLFetcher respectively, but otherwise
contained largely the same logic. Now URL request logic is abstracted
with remoting::UrlRequest interface and so a single PortAllocator
implementation can be used in all cases.
BUG=577954
Review URL: https://codereview.chromium.org/1681393006
Cr-Commit-Position: refs/heads/master@{#375042}
|
|
|
|
|
|
|
|
| |
BUG=b/19316131
Review URL: https://codereview.chromium.org/1643793002
Cr-Commit-Position: refs/heads/master@{#374209}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes changes for moving talk/media to webrtc/media which took
place in https://codereview.webrtc.org/1587193006/
WebRTC 11486:11495
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/052f590..e1bbb30
Libjingle 11485:11495
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d70be77..abc975d
TBR=perkj@chromium.org,sergeyu@chromium.org
BUG=webrtc:5420
Review URL: https://codereview.chromium.org/1669023004
Cr-Commit-Position: refs/heads/master@{#373795}
|
|
|
|
|
|
|
|
|
|
|
| |
Added two new tests that allow to measure latency of the new
WebRTC-based protocol.
BUG=547158
Review URL: https://codereview.chromium.org/1642793002
Cr-Commit-Position: refs/heads/master@{#372255}
|
|
|
|
|
|
|
|
|
|
| |
Previously FakePortAllocator didn't keep reference to TransportContext
which was causing it to be destructed prematurely and crashing
remoting_perftests.
Review URL: https://codereview.chromium.org/1644593003
Cr-Commit-Position: refs/heads/master@{#371980}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old encoder perf tests (in VideoEncoderVpxTest) were not providing
very realistic results because:
- They were measuring performance on frames with random data.
- They were testing the case when the whole frame is changing every
time.
- They were using real clock, which affects results.
This change implements new tests that provide closer approximation to
how the codec is being used.
CyclicFrameGenerator added in this test will also be used to test
performance of the new WebRTC-based protocol.
Review URL: https://codereview.chromium.org/1601303002
Cr-Commit-Position: refs/heads/master@{#370491}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously PortAllocator instances were created asynchronously in
TransportContext. Making PortAllocator synchronous allows to simplify
logic in other places, particularly in WebrtcTransport. Also simplified
PortAllocatorBase - it no longer stores STUN and Relay information and
instead instances of PortAllocatorSessionBase call TransportContext
to request fresh information when allocating ports.
Also removed duplicate logic from PepperPortAllocator and
ChromiumPortAllocator. Specifically they were filtering TCP-based relay
configs, but that's not longer necessary because PortAllocatorBase
is responsible for that now.
BUG=547158
Review URL: https://codereview.chromium.org/1571943002
Cr-Commit-Position: refs/heads/master@{#368701}
|
|
|
|
|
|
|
|
|
|
| |
cricket::HttpPortAllocatorBase is used only by chromoting,
so there is no point in keeping it in webrtc. Copied it to
src/remoting/protocol and renamed it to remoting::protocol::PortAllocatorBase.
Review URL: https://codereview.chromium.org/1567123004
Cr-Commit-Position: refs/heads/master@{#368417}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most |enum class DomCode| constants are named by mapping the names from
the W3C specification from CamelCase to SHOUTY_CASE. For the Latin
letters, named 'KeyX' in the spec, the KEY_X form conflicts with macro
definitions in <linux/input.h>. This change renames DomCode::KEY_X
constants to DomCode::US_X to avoid the conflict and to highlight
that these are positional codes corresponding to the labels
on a US QWERTY layout.
(TBR for 15 files with only spelling changes.)
R=wez@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1560293002
Cr-Commit-Position: refs/heads/master@{#368075}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moved FrameConsumer interface to remoting/protocol. This
will allow to implement video rendering in WebrtcConnectionToHost as
WebRTC stack is responsible for video decoding.
BUG=547158
Review URL: https://codereview.chromium.org/1559043004
Cr-Commit-Position: refs/heads/master@{#367600}
|
|
|
|
|
|
|
|
|
|
|
| |
VideoRenderer interface is going to be used by ConnectionToHost, so it
belongs to the protocol layer.
BUG=547158
Review URL: https://codereview.chromium.org/1559023003
Cr-Commit-Position: refs/heads/master@{#367588}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously Session implementations were responsible for creation and
ownership of Transport objects. Now Connection* classes own both
Transport and Session instances. This allows to ensure that correct
type of transport is created (i.e. WebRTC connection uses
WebrtcTransport). It also makes it possible for the host to support
two types of connections similtaneously (previously Ice connections
were not working when the host was started with --enable-webrtc).
Session is no longer responsible for tracking state of the Transport,
so it doesn't need CONNECTED state anymore. Session just passes
transport-info messages to and from transport and the Connection
object is responsible for tracking the state of the transport.
BUG=547158
Review URL: https://codereview.chromium.org/1545743002
Cr-Commit-Position: refs/heads/master@{#367003}
|
|
|
|
|
|
|
|
|
|
| |
Now there is a presubmit check that doesn't allow Pass() anymore.
See https://www.chromium.org/rvalue-references for information
about std::move in chromium.
Review URL: https://codereview.chromium.org/1545723002
Cr-Commit-Position: refs/heads/master@{#366778}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=wez@chromium.org
Review URL: https://codereview.chromium.org/1542203002
Cr-Commit-Position: refs/heads/master@{#366684}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously ConnectionToHost was responsible for monitoring state of
the signaling connection and creation of JingleSessionManager. Because
of this it was harder to test and the corresponding logic would need
to be duplicated between all implementations.
Now ChromotingClient monitors state of the signaling connection,
creates JingleSessionManager with a Session and then passes the Session
object to ConnectionToHost.
Review URL: https://codereview.chromium.org/1520323007
Cr-Commit-Position: refs/heads/master@{#365854}
|
|
|
|
|
|
|
|
|
|
| |
1. Removed Close() method.
2. Replaced Init() method with AcceptIncoming() that's called only
on the host.
Review URL: https://codereview.chromium.org/1530523002
Cr-Commit-Position: refs/heads/master@{#365702}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new TransportContext is now used to store all parameters required
to initialize Transport objects and is applicable both to IceTransport
and WebrtcTransport. It also allowed to reduce amount of boilerplate
code when passing around these parameters.
BUG=547158
Review URL: https://codereview.chromium.org/1521883006
Cr-Commit-Position: refs/heads/master@{#365649}
|
|
|
|
|
|
|
|
| |
A bunch of unit tests were deriving from base::TestSuite and telling it to not create an AtExitManager, while at the same time they were creating an AtExitManager. Just use the base::TestSuite directly which creates the AtExitManager. This follows similar cleanup I did in r362157.
Review URL: https://codereview.chromium.org/1512053002
Cr-Commit-Position: refs/heads/master@{#364590}
|
|
|
|
|
|
|
|
|
|
|
|
| |
and confirm that JID is online.
If a JID is passed in, check if a host with matching JID is online, waiting for replication delay in necessary.
BUG=543880
Review URL: https://codereview.chromium.org/1514633003
Cr-Commit-Position: refs/heads/master@{#364535}
|
|
|
|
|
|
|
|
|
|
|
| |
Previously remoting::Session was using CONNECTED state for when the
session has been accepted, but not connected. Renamed that state to
ACCEPTED and added new state CONNECTED for when the session is
authenticated and the transport is fully connected.
Review URL: https://codereview.chromium.org/1478583002
Cr-Commit-Position: refs/heads/master@{#362037}
|
|
|
|
|
|
|
|
|
|
|
| |
VideoFramePump will not be used for WebRTC-based connection. In a separate
change I plan to move creation of the VideoFramePump to IceConnectionToHost
so the host layer will not need to know when VideoFramePump needs to be
used.
Review URL: https://codereview.chromium.org/1462063004
Cr-Commit-Position: refs/heads/master@{#361205}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The recent formatter alphebetizing change is causing a lot of noise in
code reviews. Figured it'd be worth a clean-up CL.
Exact command I ran:
find . -name "*.gn*" -exec gn format --in-place "{}" \;
TBR=ddorwin@chromium.org
BUG=554928
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1464873002
Cr-Commit-Position: refs/heads/master@{#360891}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved and renamed LibjingleTransport in libjingle_transport_factory.cc
to IceTransportChannel in ice_transport_channel.cc. Removed
LibjingleTransportFactory class and moved all code to
IceTransportFactory.
BUG=547158
Review URL: https://codereview.chromium.org/1412313006
Cr-Commit-Position: refs/heads/master@{#356659}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previosly JingleSession was responsible to establishing connection
with the peer and managing list of channels. Now the new
IceTransportSession class (that implements TransportSession interface)
is responsible for managing list of channels and so it will be possible
to add support for WebRTC-based transport by adding another
TransportSession implementation.
There are no functional changes in this CL.
BUG=547158
Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b
Cr-Commit-Position: refs/heads/master@{#356588}
Review URL: https://codereview.chromium.org/1420273002
Cr-Commit-Position: refs/heads/master@{#356638}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transport. (patchset #4 id:60001 of https://codereview.chromium.org/1420273002/ )
Reason for revert:
Broke android build.
Original issue's description:
> Add TransportSession interface to prepare for WebRTC-based transport.
>
> Previosly JingleSession was responsible to establishing connection
> with the peer and managing list of channels. Now the new
> IceTransportSession class (that implements TransportSession interface)
> is responsible for managing list of channels and so it will be possible
> to add support for WebRTC-based transport by adding another
> TransportSession implementation.
>
> There are no functional changes in this CL.
>
> BUG=547158
>
> Committed: https://crrev.com/7a5351f4c6e407e456978f6599d475616a69fc0b
> Cr-Commit-Position: refs/heads/master@{#356588}
TBR=jamiewalch@chromium.org,sergeyu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=547158
Review URL: https://codereview.chromium.org/1413813006
Cr-Commit-Position: refs/heads/master@{#356595}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previosly JingleSession was responsible to establishing connection
with the peer and managing list of channels. Now the new
IceTransportSession class (that implements TransportSession interface)
is responsible for managing list of channels and so it will be possible
to add support for WebRTC-based transport by adding another
TransportSession implementation.
There are no functional changes in this CL.
BUG=547158
Review URL: https://codereview.chromium.org/1420273002
Cr-Commit-Position: refs/heads/master@{#356588}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
being less than a specified value.
These checks were included to let us know when any state transition took longer than some time, and tests would fail if that happened.
Rather than fail the tests, we should separately evaluate the numbers reported by them; that evaluation work will be done outside the flow of the Chromoting builders.
BUG=
Review URL: https://codereview.chromium.org/1414443003
Cr-Commit-Position: refs/heads/master@{#354612}
|
|
|
|
|
|
|
|
| |
This turns out to be a bit more churn than I'd hoped because ui/events/keycodes/dom/dom_code.h declares a strongly-typed enum, which can't be compared to unsigned int without a cast. Overall, I like the safety of typed enums, so I added the casts rather than declaring our own untyped equivalent, but LMK if you would prefer that.
Review URL: https://codereview.chromium.org/1403583003
Cr-Commit-Position: refs/heads/master@{#353626}
|
|
|
|
|
|
|
|
|
| |
The previous code was creating a new temporary object rather than
delegating to the other constructor.
Review URL: https://codereview.chromium.org/1367533008
Cr-Commit-Position: refs/heads/master@{#350583}
|
|
|
|
|
|
|
|
|
|
|
| |
Since these environments are no longer present, I am removing them from
the test tool to prevent anyone from attempting to target them.
BUG=
Review URL: https://codereview.chromium.org/1357973002
Cr-Commit-Position: refs/heads/master@{#350256}
|
|
|
|
|
|
|
|
| |
BUG=533172
Review URL: https://codereview.chromium.org/1352063003
Cr-Commit-Position: refs/heads/master@{#349598}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously PerformanceTracker was owned by VideoRenderer
implementations. Move it to ChromotingInstance and
ChromotingJniInstance because the tracker will be responsible for
tracking all performance stats that may not be related to video
rendering.
Review URL: https://codereview.chromium.org/1353443003
Cr-Commit-Position: refs/heads/master@{#349498}
|
|
|
|
|
|
|
|
|
|
| |
The class will be used directly from protocol dispatchers, so it needs
to be accessible on the protocol layer. Also renamed it so the name
reflects what the class is responsible for.
Review URL: https://codereview.chromium.org/1351723004
Cr-Commit-Position: refs/heads/master@{#349295}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 9918:9920
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8f226a6..0938a04
Libjingle 9915:9920
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/f150b27..df5ede1
TBR=sergeyu@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1333043002
Cr-Commit-Position: refs/heads/master@{#348300}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection.
All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up.
Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency.
I moved a config out of a target in yasm, and sorted a fews deps on other targets.
TBR=xhwang@chromium.org (widevine)
TBR=achuith@chromium.org (tools/perf, tools/telemetry)
Review URL: https://codereview.chromium.org/1318343003
Cr-Commit-Position: refs/heads/master@{#346490}
|