summaryrefslogtreecommitdiffstats
path: root/rlz/win
Commit message (Collapse)AuthorAgeFilesLines
* Switch to standard integer types in rlz/.avi2015-12-229-8/+21
| | | | | | | | | BUG=138542 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1547683004 Cr-Commit-Position: refs/heads/master@{#366614}
* clang/win: Let remaining chromium_code targets build with -Wextra.thakis2015-12-103-3/+3
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/1507413003/ and lets all translation units in a release build build if -Wextra is enabled for chromium_code targets. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 Review URL: https://codereview.chromium.org/1513043002 Cr-Commit-Position: refs/heads/master@{#364425}
* Remove a block of rlz code for when _WIN32_WINNT < 0x500.thestig2015-09-181-24/+0
| | | | | | Review URL: https://codereview.chromium.org/1352973002 Cr-Commit-Position: refs/heads/master@{#349707}
* Remove remaining legacy SplitString calls.brettw2015-08-121-2/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* Remove legacy StartsWithASCII function.brettw2015-07-161-1/+2
| | | | | | | | | | | This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change. BUG=506255 TBR=jam Review URL: https://codereview.chromium.org/1242023005 Cr-Commit-Position: refs/heads/master@{#339175}
* Fix some clang warnings with -Wmissing-braces in rlz.dcheng2015-07-011-1/+1
| | | | | | | | | | | Clang warns if there are missing braces around a subobject initializer. BUG=505297 Review URL: https://codereview.chromium.org/1215533005 Cr-Commit-Position: refs/heads/master@{#337085}
* Move more string_util functions to base namespace.brettw2015-06-241-1/+1
| | | | | | | | | | | | | | Rename IsWhitespace to IsUnicodeWhitespace (to contrast it to the already-existing IsAsciiWhitespace). De-inline HexDigitToInt. This is only used in a few places and I don't think it's necessary to inline. Remove some redundant base:: qualifications in base. TBR=sky Review URL: https://codereview.chromium.org/1200053004 Cr-Commit-Position: refs/heads/master@{#335827}
* Move StartsWith[ASCII] to base namespace.brettw2015-06-121-1/+1
| | | | | | | | | NOPRESUBMIT=true (no presubmit due to removing base:: from a ScopedAllowIO) Review URL: https://codereview.chromium.org/1172183002 Cr-Commit-Position: refs/heads/master@{#334108}
* Update {virtual,override} to follow C++11 style in rlz.nick2015-04-231-15/+15
| | | | | | | | | | | | The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Review URL: https://codereview.chromium.org/1097393008 Cr-Commit-Position: refs/heads/master@{#326517}
* Move GetProcessIntegrityLevel to file_info.h and remove the handle argument.rvargas2015-02-132-16/+12
| | | | | | | | BUG=417532 Review URL: https://codereview.chromium.org/921913002 Cr-Commit-Position: refs/heads/master@{#316242}
* Cleanup: Get rid of base::ASCIIToWide().thestig2014-12-084-51/+44
| | | | | | | | BUG=23581 Review URL: https://codereview.chromium.org/768973003 Cr-Commit-Position: refs/heads/master@{#307333}
* fix RLZ crasher in process_info.cccpu2014-11-051-75/+8
| | | | | | | | | | | | | | | RLZ is using a very convoluted and fragile way to check for code running as NT/SYSTEM. - It can fail, which causes a crash - It is quite slow on domains - It is incorrect because "SYSTEM" is not the string in some locales. BUG=428944 Review URL: https://codereview.chromium.org/691913003 Cr-Commit-Position: refs/heads/master@{#302741}
* Fixing rlz mutexcpu2014-10-292-48/+11
| | | | | | | | | | | | | | | | 0 - Remove special case for Vista. 1- Remove the low integrity logic, broken, wether or not to wait has nothing to do with setting the low integrity label, which was racy and (sometimes) broken. 2- Cleanup of style. BUG=426573 Review URL: https://codereview.chromium.org/686733003 Cr-Commit-Position: refs/heads/master@{#301748}
* Replace OVERRIDE with its C++11 counterparts in src/rlzr.nagaraj2014-10-091-15/+15
| | | | | | | | | | | This step is a giant search for OVERRIDE to replace it with its lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/633353002 Cr-Commit-Position: refs/heads/master@{#298863}
* Revert of Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-311-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/) Reason for revert: Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.) Original issue's description: > Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) > > Reason for revert: > Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 > > InstallerStateTest.InitializeTwice (run #1): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) > > InstallerStateTest.InitializeTwice (run #2): > [ RUN ] InstallerStateTest.InitializeTwice > c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) > Actual: false > Expected: true > [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) > > > Original issue's description: > > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > > > Also don't use "default" as a variable name, as it's a keyword. > > Also fix a bug where a wstring was passed to %ls. > > > > No real behavior change. > > > > BUG=82385 > > R=hans@chromium.org > > TBR=cpu, vitalybuka > > > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 > > TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=82385 > > Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/525013003 Cr-Commit-Position: refs/heads/master@{#292818}
* Revert of clang/win: Fix a few warnings in targets not in ↵thakis2014-08-301-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/) Reason for revert: Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481 InstallerStateTest.InitializeTwice (run #1): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (219 ms) InstallerStateTest.InitializeTwice (run #2): [ RUN ] InstallerStateTest.InitializeTwice c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str()) Actual: false Expected: true [ FAILED ] InstallerStateTest.InitializeTwice (109 ms) Original issue's description: > clang/win: Fix a few warnings in targets not in chromium_builder_tests. > > Also don't use "default" as a variable name, as it's a keyword. > Also fix a bug where a wstring was passed to %ls. > > No real behavior change. > > BUG=82385 > R=hans@chromium.org > TBR=cpu, vitalybuka > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09 TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=82385 Review URL: https://codereview.chromium.org/519463003 Cr-Commit-Position: refs/heads/master@{#292809}
* clang/win: Fix a few warnings in targets not in chromium_builder_tests.Nico Weber2014-08-291-7/+7
| | | | | | | | | | | | | | | Also don't use "default" as a variable name, as it's a keyword. Also fix a bug where a wstring was passed to %ls. No real behavior change. BUG=82385 R=hans@chromium.org TBR=cpu, vitalybuka Review URL: https://codereview.chromium.org/526513002 Cr-Commit-Position: refs/heads/master@{#292699}
* clang/win: Fix most -Wwriteable-strings warnings.thakis@chromium.org2014-07-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | Many win32 APIs take non-const string pointers. I checked that MSDN documents them as _In_ and says that they are inputs, and then added const_cast<>s at the calling sites. (In one test, I introduced a helper struct so that there can be fewer casts.) This wasn't just busywork, I found one function that we were handing string literals where the documentation explicitly said that that's not valid (filed http://crbug.com/396705). I didn't change the DECLARE_REGISTRY_APPID_RESOURCEID() call in cloud_print; it sounds like that'll fix itself when we update to the 2014 sdk: http://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013 BUG=396705,82385 R=rnk@chromium.org, rsleevi@chromium.org, sergeyu@chromium.org, vitalybuka@chromium.org Review URL: https://codereview.chromium.org/413763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285051 0039d316-1c4b-4281-b951-d872f2087c98
* clang/win: Fix a Wenum-compare warning and a few Wwritable-strings warnings.thakis@chromium.org2014-07-212-8/+1
| | | | | | | | | | BUG=82385 R=rnk@chromium.org TBR=jochen Review URL: https://codereview.chromium.org/405123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284447 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetUserName() return more specific error code, so that we could know ↵yiyaoliu@chromium.org2014-03-101-14/+9
| | | | | | | | | | | | how the function failed. However, a lot user at under version 33 or lower, which means they don't auto-update Chrome? I'm not sure if this new piece of code will get to the affected users. BUG=334675 Review URL: https://codereview.chromium.org/177843009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255985 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in ppapi/, printing/, remoting/, rlz/, ↵avi@chromium.org2013-12-252-2/+4
| | | | | | | | | | | | sandbox/, skia/, sql/, sync/, tools/, webkit/, win8/ to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/121123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242502 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16 in rlz/.dbeam@chromium.org2013-12-191-1/+1
| | | | | | | | | R=rogerta@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/102833007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241896 0039d316-1c4b-4281-b951-d872f2087c98
* Use RegistryOverrideManager properly in RLZ tests.grt@chromium.org2013-11-144-110/+3
| | | | | | | | | | | | | | | | | Previously, rlz/test/rlz_test_helpers.cc and chrome/browser/rlz/rlz_unittest.cc each did somewhat different things to prepare the registry for tests. Now, rlz_test_helpers.cc does the prep the right way using RegistryOverrideManager and rlz_unittests.cc uses rlz_test_helpers.cc. This unblocks the refactor in r234367 that was reverted in r234627. BUG=314800 R=rogerta@chromium.org, tommycli@chromium.org Review URL: https://codereview.chromium.org/63153009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235090 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in rlz for base/process changes.rsesek@chromium.org2013-07-232-2/+2
| | | | | | | | | BUG=242290 R=rogerta@chromium.org Review URL: https://chromiumcodereview.appspot.com/19851004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213171 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in rlz/, sandbox/, skia/, sql/, sync/.avi@chromium.org2013-06-113-4/+4
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16358024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205458 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in google_apis/, gpu/, ↵avi@chromium.org2013-06-072-3/+3
| | | | | | | | | | | | ipc/, media/, ppapi/, printing/, remoting/, rlz/, skia/, sql/, sync/, third_party/, tools/, webkit/, win8/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15995038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204967 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_array<T> to scoped_ptr<T[]> in rlz.dcheng@chromium.org2013-04-113-3/+3
| | | | | | | | | | | | This is a manual cleanup pass using sed for files which are not built on Linux. BUG=171111 Review URL: https://chromiumcodereview.appspot.com/14114002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193534 0039d316-1c4b-4281-b951-d872f2087c98
* src/: Update the remaining include paths of string_split.h to its new location.tfarina@chromium.org2013-03-061-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186462 0039d316-1c4b-4281-b951-d872f2087c98
* [RLZ] Get rid of vista_winnt.hmnaganov@chromium.org2013-02-032-100/+0
| | | | | | | | | | | This file was needed for compiling on pre-Vista SDKs. Since now Chromium requires at least Windows 7 SDK, it should not be needed anymore. BUG=172607 Review URL: https://chromiumcodereview.appspot.com/12092068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180289 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144071 - Add a regenerate button to regenerate the password in Windows.jam@chromium.org2012-06-2617-0/+2053
| | | | | | | | | | | | | BUG=120480 TEST=Not tested. Review URL: https://chromiumcodereview.appspot.com/10642009 TBR=zysxqn@google.com Review URL: https://chromiumcodereview.appspot.com/10659022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144074 0039d316-1c4b-4281-b951-d872f2087c98
* Add a regenerate button to regenerate the password in Windows.zysxqn@google.com2012-06-2617-2053/+0
| | | | | | | | | | BUG=120480 TEST=Not tested. Review URL: https://chromiumcodereview.appspot.com/10642009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144071 0039d316-1c4b-4281-b951-d872f2087c98
* Check-in rlz code to src\rlz from http://code.google.com/p/rlz/.jam@chromium.org2012-06-2117-0/+2053
Review URL: https://chromiumcodereview.appspot.com/10597002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143381 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-21 06:26:40 +0000