diff options
author | jbauman@chromium.org <jbauman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 04:05:05 +0000 |
---|---|---|
committer | jbauman@chromium.org <jbauman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-29 04:05:05 +0000 |
commit | 4b15766b5d7cf3cf642d6c745f2ea87cda351063 (patch) | |
tree | 1c06997a265b6463a64b381636ab7618c28e4945 /cc/output | |
parent | 48ff0819e2af591419f0ac1209c4138123f8e9b8 (diff) | |
download | chromium_src-4b15766b5d7cf3cf642d6c745f2ea87cda351063.zip chromium_src-4b15766b5d7cf3cf642d6c745f2ea87cda351063.tar.gz chromium_src-4b15766b5d7cf3cf642d6c745f2ea87cda351063.tar.bz2 |
Move cc/debug/latency_info to ui/base.
This structure would be useful in ui/surface, which can't depend on cc/.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14999012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202772 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'cc/output')
-rw-r--r-- | cc/output/compositor_frame_metadata.h | 4 | ||||
-rw-r--r-- | cc/output/delegating_renderer.cc | 2 | ||||
-rw-r--r-- | cc/output/delegating_renderer.h | 2 | ||||
-rw-r--r-- | cc/output/gl_renderer.cc | 2 | ||||
-rw-r--r-- | cc/output/gl_renderer.h | 2 | ||||
-rw-r--r-- | cc/output/gl_renderer_unittest.cc | 20 | ||||
-rw-r--r-- | cc/output/output_surface.cc | 4 | ||||
-rw-r--r-- | cc/output/output_surface.h | 7 | ||||
-rw-r--r-- | cc/output/renderer.h | 4 | ||||
-rw-r--r-- | cc/output/software_renderer.cc | 2 | ||||
-rw-r--r-- | cc/output/software_renderer.h | 2 |
11 files changed, 26 insertions, 25 deletions
diff --git a/cc/output/compositor_frame_metadata.h b/cc/output/compositor_frame_metadata.h index 55ee9da..4e569bb 100644 --- a/cc/output/compositor_frame_metadata.h +++ b/cc/output/compositor_frame_metadata.h @@ -6,7 +6,7 @@ #define CC_OUTPUT_COMPOSITOR_FRAME_METADATA_H_ #include "cc/base/cc_export.h" -#include "cc/debug/latency_info.h" +#include "ui/base/latency_info.h" #include "ui/gfx/size_f.h" #include "ui/gfx/vector2d_f.h" @@ -38,7 +38,7 @@ class CC_EXPORT CompositorFrameMetadata { gfx::Vector2dF location_bar_content_translation; float overdraw_bottom_height; - LatencyInfo latency_info; + ui::LatencyInfo latency_info; }; } // namespace cc diff --git a/cc/output/delegating_renderer.cc b/cc/output/delegating_renderer.cc index 3b5839e..ea034b0 100644 --- a/cc/output/delegating_renderer.cc +++ b/cc/output/delegating_renderer.cc @@ -156,7 +156,7 @@ void DelegatingRenderer::DrawFrame( resource_provider_->PrepareSendToParent(resources, &out_data.resource_list); } -void DelegatingRenderer::SwapBuffers(const LatencyInfo& latency_info) { +void DelegatingRenderer::SwapBuffers(const ui::LatencyInfo& latency_info) { TRACE_EVENT0("cc", "DelegatingRenderer::SwapBuffers"); output_surface_->SendFrameToParentCompositor(&frame_for_swap_buffers_); diff --git a/cc/output/delegating_renderer.h b/cc/output/delegating_renderer.h index 6e659c0..ef44f79 100644 --- a/cc/output/delegating_renderer.h +++ b/cc/output/delegating_renderer.h @@ -32,7 +32,7 @@ class CC_EXPORT DelegatingRenderer : public Renderer { virtual void Finish() OVERRIDE {} - virtual void SwapBuffers(const LatencyInfo& latency_info) OVERRIDE; + virtual void SwapBuffers(const ui::LatencyInfo& latency_info) OVERRIDE; virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) OVERRIDE; diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc index 7d37920..1afb384 100644 --- a/cc/output/gl_renderer.cc +++ b/cc/output/gl_renderer.cc @@ -1960,7 +1960,7 @@ void GLRenderer::Finish() { context_->finish(); } -void GLRenderer::SwapBuffers(const LatencyInfo& latency_info) { +void GLRenderer::SwapBuffers(const ui::LatencyInfo& latency_info) { DCHECK(visible_); DCHECK(!is_backbuffer_discarded_); diff --git a/cc/output/gl_renderer.h b/cc/output/gl_renderer.h index d90b32f..d4b7e1a 100644 --- a/cc/output/gl_renderer.h +++ b/cc/output/gl_renderer.h @@ -61,7 +61,7 @@ class CC_EXPORT GLRenderer virtual void DoNoOp() OVERRIDE; // Puts backbuffer onscreen. - virtual void SwapBuffers(const LatencyInfo& latency_info) OVERRIDE; + virtual void SwapBuffers(const ui::LatencyInfo& latency_info) OVERRIDE; virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) OVERRIDE; diff --git a/cc/output/gl_renderer_unittest.cc b/cc/output/gl_renderer_unittest.cc index 7e1a438..48a5951 100644 --- a/cc/output/gl_renderer_unittest.cc +++ b/cc/output/gl_renderer_unittest.cc @@ -268,7 +268,7 @@ class GLRendererTest : public testing::Test { virtual void SetUp() { renderer_.Initialize(); } - void SwapBuffers() { renderer_.SwapBuffers(LatencyInfo()); } + void SwapBuffers() { renderer_.SwapBuffers(ui::LatencyInfo()); } FrameCountingMemoryAllocationSettingContext* Context() { return static_cast<FrameCountingMemoryAllocationSettingContext*>( @@ -1482,8 +1482,8 @@ class MockOutputSurface : public OutputSurface { MOCK_METHOD0(DiscardBackbuffer, void()); MOCK_METHOD2(Reshape, void(gfx::Size size, float scale_factor)); MOCK_METHOD0(BindFramebuffer, void()); - MOCK_METHOD2(PostSubBuffer, void(gfx::Rect rect, const LatencyInfo&)); - MOCK_METHOD1(SwapBuffers, void(const LatencyInfo&)); + MOCK_METHOD2(PostSubBuffer, void(gfx::Rect rect, const ui::LatencyInfo&)); + MOCK_METHOD1(SwapBuffers, void(const ui::LatencyInfo&)); }; class MockOutputSurfaceTest : public testing::Test, public FakeRendererClient { @@ -1494,7 +1494,7 @@ class MockOutputSurfaceTest : public testing::Test, public FakeRendererClient { virtual void SetUp() { EXPECT_TRUE(renderer_.Initialize()); } - void SwapBuffers() { renderer_.SwapBuffers(LatencyInfo()); } + void SwapBuffers() { renderer_.SwapBuffers(ui::LatencyInfo()); } void DrawFrame() { gfx::Rect viewport_rect(DeviceViewportSize()); @@ -1536,31 +1536,31 @@ TEST_F(MockOutputSurfaceTest, DrawFrameAndSwap) { DrawFrame(); EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); } TEST_F(MockOutputSurfaceTest, DrawFrameAndResizeAndSwap) { DrawFrame(); EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); set_viewport_and_scale(gfx::Size(2, 2), 2.f); renderer_.ViewportChanged(); DrawFrame(); EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); DrawFrame(); EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); set_viewport_and_scale(gfx::Size(1, 1), 1.f); renderer_.ViewportChanged(); DrawFrame(); EXPECT_CALL(output_surface_, SwapBuffers(_)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); } class MockOutputSurfaceTestWithPartialSwap : public MockOutputSurfaceTest { @@ -1576,7 +1576,7 @@ TEST_F(MockOutputSurfaceTestWithPartialSwap, DrawFrameAndSwap) { DrawFrame(); EXPECT_CALL(output_surface_, PostSubBuffer(_, _)).Times(1); - renderer_.SwapBuffers(LatencyInfo()); + renderer_.SwapBuffers(ui::LatencyInfo()); } class MockOutputSurfaceTestWithSendCompositorFrame diff --git a/cc/output/output_surface.cc b/cc/output/output_surface.cc index ffc0b2a..6c46769 100644 --- a/cc/output/output_surface.cc +++ b/cc/output/output_surface.cc @@ -121,7 +121,7 @@ void OutputSurface::BindFramebuffer() { context3d_->bindFramebuffer(GL_FRAMEBUFFER, 0); } -void OutputSurface::SwapBuffers(const LatencyInfo& latency_info) { +void OutputSurface::SwapBuffers(const ui::LatencyInfo& latency_info) { DCHECK(context3d_); // Note that currently this has the same effect as SwapBuffers; we should // consider exposing a different entry point on WebGraphicsContext3D. @@ -129,7 +129,7 @@ void OutputSurface::SwapBuffers(const LatencyInfo& latency_info) { } void OutputSurface::PostSubBuffer(gfx::Rect rect, - const LatencyInfo& latency_info) { + const ui::LatencyInfo& latency_info) { DCHECK(context3d_); context3d_->postSubBufferCHROMIUM( rect.x(), rect.y(), rect.width(), rect.height()); diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h index fb6f0b9..a021ebf 100644 --- a/cc/output/output_surface.h +++ b/cc/output/output_surface.h @@ -11,6 +11,8 @@ #include "cc/output/software_output_device.h" #include "third_party/WebKit/Source/Platform/chromium/public/WebGraphicsContext3D.h" +namespace ui { struct LatencyInfo; } + namespace gfx { class Rect; class Size; @@ -21,7 +23,6 @@ namespace cc { class CompositorFrame; class OutputSurfaceClient; class OutputSurfaceCallbacks; -struct LatencyInfo; // Represents the output surface for a compositor. The compositor owns // and manages its destruction. Its lifetime is: @@ -91,8 +92,8 @@ class CC_EXPORT OutputSurface { virtual void BindFramebuffer(); - virtual void PostSubBuffer(gfx::Rect rect, const LatencyInfo&); - virtual void SwapBuffers(const LatencyInfo&); + virtual void PostSubBuffer(gfx::Rect rect, const ui::LatencyInfo&); + virtual void SwapBuffers(const ui::LatencyInfo&); // Notifies frame-rate smoothness preference. If true, all non-critical // processing should be stopped, or lowered in priority. diff --git a/cc/output/renderer.h b/cc/output/renderer.h index 5592090..aaf9fd7 100644 --- a/cc/output/renderer.h +++ b/cc/output/renderer.h @@ -7,10 +7,10 @@ #include "base/basictypes.h" #include "cc/base/cc_export.h" -#include "cc/debug/latency_info.h" #include "cc/quads/render_pass.h" #include "cc/resources/managed_memory_policy.h" #include "cc/trees/layer_tree_host.h" +#include "ui/base/latency_info.h" namespace cc { @@ -69,7 +69,7 @@ class CC_EXPORT Renderer { virtual void DoNoOp() {} // Puts backbuffer onscreen. - virtual void SwapBuffers(const LatencyInfo& latency_info) = 0; + virtual void SwapBuffers(const ui::LatencyInfo& latency_info) = 0; virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) = 0; diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc index 4a337ff..b555b57 100644 --- a/cc/output/software_renderer.cc +++ b/cc/output/software_renderer.cc @@ -107,7 +107,7 @@ void SoftwareRenderer::FinishDrawingFrame(DrawingFrame* frame) { } } -void SoftwareRenderer::SwapBuffers(const LatencyInfo& latency_info) { +void SoftwareRenderer::SwapBuffers(const ui::LatencyInfo& latency_info) { if (Settings().compositor_frame_message) output_surface_->SendFrameToParentCompositor(&compositor_frame_); } diff --git a/cc/output/software_renderer.h b/cc/output/software_renderer.h index 72a5052..cbaf1d3 100644 --- a/cc/output/software_renderer.h +++ b/cc/output/software_renderer.h @@ -35,7 +35,7 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer { virtual const RendererCapabilities& Capabilities() const OVERRIDE; virtual void ViewportChanged() OVERRIDE; virtual void Finish() OVERRIDE; - virtual void SwapBuffers(const LatencyInfo& latency_info) OVERRIDE; + virtual void SwapBuffers(const ui::LatencyInfo& latency_info) OVERRIDE; virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) OVERRIDE; virtual void SetVisible(bool visible) OVERRIDE; virtual void SendManagedMemoryStats( |