summaryrefslogtreecommitdiffstats
path: root/build/get_landmines.py
Commit message (Collapse)AuthorAgeFilesLines
* New VS 2015 toolchain from 2016_03_10brucedawson2016-03-151-1/+1
| | | | | | | | BUG=440500 Review URL: https://codereview.chromium.org/1796933002 Cr-Commit-Position: refs/heads/master@{#381221}
* Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵brucedawson2016-03-111-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1778343002/ ) Reason for revert: Preparing a revert in order to reland VS 2015. The CL is not reading for committing yet. Original issue's description: > Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1740583002/ ) > > Reason for revert: > Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg). > > Original issue's description: > > Reland of Change default Windows compiler to VS 2015 > > > > The change to get_landmines.py is there because modifying this file > > affects analyze behavior so that all tests run. Changing the printed > > message is purely a side effect. > > > > This change also removes some redundant INCLUDE paths. These are > > unnecessary when building with VS 2015 (because it defaults to the > > Windows 10 SDK) and actively harmful (they make the INCLUDE path > > problematically long). > > > > This change was redone in order to fix merge conflicts and because after > > a few weeks a fresh set of approvals seems reasonable. > > > > The original change was landed as crrev.com/1598493004 > > > > BUG=440500, 584782 > > > > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b > > Cr-Commit-Position: refs/heads/master@{#380382} > > TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=440500, 584782 > > Committed: https://crrev.com/cb3f85f80a2c146e0e4bf064f02bf68acb274ce5 > Cr-Commit-Position: refs/heads/master@{#380395} TBR=scottmg@chromium.org,dpranke@chromium.org,vasilii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500, 584782 Review URL: https://codereview.chromium.org/1783773004 Cr-Commit-Position: refs/heads/master@{#380711}
* Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵vasilii2016-03-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1740583002/ ) Reason for revert: Broke isolate tests on Win8 GN (dbg) and Win x64 GN (dbg). https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/22695/steps/isolate%20tests/logs/stdio [found] [hashed/size/to hash] [looked up/to lookup] [uploaded/size/to upload/size] 04:10:31.512494 Root: E:\b\build\slave\Win8_GN__dbg_\build\src 04:10:31.513479 Root: E:\b\build\slave\Win8_GN__dbg_\build\src events_unittests GetFileAttributesEx E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system cannot find the file specified. 04:10:31.988532 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\content\test\data\) = 1574 files 04:10:32.060523 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\media\test\data\) = 233 files 04:10:32.435549 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\net\data\) = 974 files 04:10:32.464549 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\net\tools\testserver\) = 11 files [2843] [6/29.0Mib/39] [0/6] [0/0b/0/0b] 1s 04:10:32.505555 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\pyftpdlib\) = 37 files 04:10:32.539557 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\pywebsocket\) = 99 files 04:10:32.578571 PushDirectory(E:\b\build\slave\Win8_GN__dbg_\build\src\third_party\tlslite\) = 105 files content_browsertests GetFileAttributesEx E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system cannot find the file specified. Hits : 0 (0b) Misses : 0 (0b) Duration: 1.301s isolate: GetFileAttributesEx E:\b\build\slave\Win8_GN__dbg_\build\src\out\Debug\msvcp120d.dll: The system cannot find the file specified. step returned non-zero exit code: 1 Original issue's description: > Reland of Change default Windows compiler to VS 2015 > > The change to get_landmines.py is there because modifying this file > affects analyze behavior so that all tests run. Changing the printed > message is purely a side effect. > > This change also removes some redundant INCLUDE paths. These are > unnecessary when building with VS 2015 (because it defaults to the > Windows 10 SDK) and actively harmful (they make the INCLUDE path > problematically long). > > This change was redone in order to fix merge conflicts and because after > a few weeks a fresh set of approvals seems reasonable. > > The original change was landed as crrev.com/1598493004 > > BUG=440500, 584782 > > Committed: https://crrev.com/d4dcbd342dd54f55383daf8bc44b2c9d97fe0d0b > Cr-Commit-Position: refs/heads/master@{#380382} TBR=scottmg@chromium.org,dpranke@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500, 584782 Review URL: https://codereview.chromium.org/1778343002 Cr-Commit-Position: refs/heads/master@{#380395}
* Reland of Change default Windows compiler to VS 2015brucedawson2016-03-101-3/+1
| | | | | | | | | | | | | | | | | | | | | | The change to get_landmines.py is there because modifying this file affects analyze behavior so that all tests run. Changing the printed message is purely a side effect. This change also removes some redundant INCLUDE paths. These are unnecessary when building with VS 2015 (because it defaults to the Windows 10 SDK) and actively harmful (they make the INCLUDE path problematically long). This change was redone in order to fix merge conflicts and because after a few weeks a fresh set of approvals seems reasonable. The original change was landed as crrev.com/1598493004 BUG=440500, 584782 Review URL: https://codereview.chromium.org/1740583002 Cr-Commit-Position: refs/heads/master@{#380382}
* Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵blundell2016-02-091-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1676263003/ ) Reason for revert: Speculative revert to see if it fixes the "Duplicate COMDAT" compile error; will reland if it doesn't. Googling indicates that we have fought with "Duplicate COMDAT" errors in the past as part of trying to bring in VS 2015. This error occurred in #374346, which is a revert of #374322 due to that CL causing test failures on Linux. Note that the Windows compiler switch landed in #374324. Here is the error in question (from https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=18343): FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True mojo_system_impl.dll "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:mojo_system_impl.dll.lib /DLL /OUT:mojo_system_impl.dll @mojo_system_impl.dll.rsp" 2 mt.exe rc.exe "obj\third_party\mojo\mojo_system_impl.mojo_system_impl.dll.intermediate.manifest" obj\third_party\mojo\mojo_system_impl.mojo_system_impl.dll.generated.manifest mojo_system_impl2.node_controller.obj : fatal error LNK1179: invalid or corrupt file: duplicate COMDAT '??1?$Callback@$$A6AXAEBVPortRef@ports@edk@mojo@@@Z@base@@QEAA@XZ' Original issue's description: > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1680533004/ ) > > Reason for revert: > The GPU bot problem (a bug with swarming tests on component builds) is fixed with crrev.com/1676943002 > > Original issue's description: > > Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1679693002/ ) > > > > Reason for revert: > > This breaks GPU win debug bots (https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/36633 for example, every GPU test is crashing) > > > > Original issue's description: > > > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1678663002/ ) > > > > > > Reason for revert: > > > Issues that forced revert of VS 2015 as default compiler are believed to be fixed. > > > > > > Original issue's description: > > > > Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ ) > > > > > > > > Reason for revert: > > > > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. > > > > > > > > Original issue's description: > > > > > Change default Windows compiler to VS 2015 > > > > > > > > > > The change to get_landmines.py is there because modifying this file > > > > > affects analyze behavior so that all tests run. Changing the printed > > > > > message is purely a side effect. > > > > > > > > > > This change also removes some redundant INCLUDE paths. These are > > > > > unnecessary when building with VS 2015 (because it defaults to the > > > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path > > > > > problematically long). > > > > > > > > > > BUG=440500,584782 > > > > > > > > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > > > > > Cr-Commit-Position: refs/heads/master@{#373955} > > > > > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > NOPRESUBMIT=true > > > > NOTREECHECKS=true > > > > NOTRY=true > > > > BUG=440500,584782 > > > > > > > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 > > > > Cr-Commit-Position: refs/heads/master@{#374013} > > > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=440500,584782 > > > > > > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3 > > > Cr-Commit-Position: refs/heads/master@{#374058} > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,brucedawson@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=440500,584782 > > > > Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8 > > Cr-Commit-Position: refs/heads/master@{#374062} > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,zmo@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=440500,584782 > > Committed: https://crrev.com/36f03f2ac1f92b6f41129f013f8a808f7b9127fc > Cr-Commit-Position: refs/heads/master@{#374324} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,zmo@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500,584782 Review URL: https://codereview.chromium.org/1680123002 Cr-Commit-Position: refs/heads/master@{#374349}
* Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵brucedawson2016-02-091-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1680533004/ ) Reason for revert: The GPU bot problem (a bug with swarming tests on component builds) is fixed with crrev.com/1676943002 Original issue's description: > Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1679693002/ ) > > Reason for revert: > This breaks GPU win debug bots (https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/36633 for example, every GPU test is crashing) > > Original issue's description: > > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1678663002/ ) > > > > Reason for revert: > > Issues that forced revert of VS 2015 as default compiler are believed to be fixed. > > > > Original issue's description: > > > Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ ) > > > > > > Reason for revert: > > > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. > > > > > > Original issue's description: > > > > Change default Windows compiler to VS 2015 > > > > > > > > The change to get_landmines.py is there because modifying this file > > > > affects analyze behavior so that all tests run. Changing the printed > > > > message is purely a side effect. > > > > > > > > This change also removes some redundant INCLUDE paths. These are > > > > unnecessary when building with VS 2015 (because it defaults to the > > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path > > > > problematically long). > > > > > > > > BUG=440500,584782 > > > > > > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > > > > Cr-Commit-Position: refs/heads/master@{#373955} > > > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=440500,584782 > > > > > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 > > > Cr-Commit-Position: refs/heads/master@{#374013} > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=440500,584782 > > > > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3 > > Cr-Commit-Position: refs/heads/master@{#374058} > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=440500,584782 > > Committed: https://crrev.com/03f6b0af0a3a0127f5e939095157079659ab7cc8 > Cr-Commit-Position: refs/heads/master@{#374062} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=440500,584782 Review URL: https://codereview.chromium.org/1676263003 Cr-Commit-Position: refs/heads/master@{#374324}
* Revert of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵zmo2016-02-071-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1679693002/ ) Reason for revert: This breaks GPU win debug bots (https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/36633 for example, every GPU test is crashing) Original issue's description: > Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of https://codereview.chromium.org/1678663002/ ) > > Reason for revert: > Issues that forced revert of VS 2015 as default compiler are believed to be fixed. > > Original issue's description: > > Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ ) > > > > Reason for revert: > > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. > > > > Original issue's description: > > > Change default Windows compiler to VS 2015 > > > > > > The change to get_landmines.py is there because modifying this file > > > affects analyze behavior so that all tests run. Changing the printed > > > message is purely a side effect. > > > > > > This change also removes some redundant INCLUDE paths. These are > > > unnecessary when building with VS 2015 (because it defaults to the > > > Windows 10 SDK) and actively harmful (they make the INCLUDE path > > > problematically long). > > > > > > BUG=440500,584782 > > > > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > > > Cr-Commit-Position: refs/heads/master@{#373955} > > > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=440500,584782 > > > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 > > Cr-Commit-Position: refs/heads/master@{#374013} > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=440500,584782 > > Committed: https://crrev.com/20e99ecb08da22582d435c1a5bba0a5c96345da3 > Cr-Commit-Position: refs/heads/master@{#374058} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500,584782 Review URL: https://codereview.chromium.org/1680533004 Cr-Commit-Position: refs/heads/master@{#374062}
* Reland of Change default Windows compiler to VS 2015 (patchset #1 id:1 of ↵brucedawson2016-02-071-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1678663002/ ) Reason for revert: Issues that forced revert of VS 2015 as default compiler are believed to be fixed. Original issue's description: > Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 of https://codereview.chromium.org/1598493004/ ) > > Reason for revert: > Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. > > Original issue's description: > > Change default Windows compiler to VS 2015 > > > > The change to get_landmines.py is there because modifying this file > > affects analyze behavior so that all tests run. Changing the printed > > message is purely a side effect. > > > > This change also removes some redundant INCLUDE paths. These are > > unnecessary when building with VS 2015 (because it defaults to the > > Windows 10 SDK) and actively harmful (they make the INCLUDE path > > problematically long). > > > > BUG=440500,584782 > > > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > > Cr-Commit-Position: refs/heads/master@{#373955} > > TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=440500,584782 > > Committed: https://crrev.com/bbc766aef1bd8cb0d9546fec9abf264e7d8c1d96 > Cr-Commit-Position: refs/heads/master@{#374013} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=440500,584782 Review URL: https://codereview.chromium.org/1679693002 Cr-Commit-Position: refs/heads/master@{#374058}
* Revert of Change default Windows compiler to VS 2015 (patchset #10 id:180001 ↵thakis2016-02-061-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1598493004/ ) Reason for revert: Speculative for https://code.google.com/p/chromium/issues/detail?id=498544#c20 . Will reland if this doesn't help. Original issue's description: > Change default Windows compiler to VS 2015 > > The change to get_landmines.py is there because modifying this file > affects analyze behavior so that all tests run. Changing the printed > message is purely a side effect. > > This change also removes some redundant INCLUDE paths. These are > unnecessary when building with VS 2015 (because it defaults to the > Windows 10 SDK) and actively harmful (they make the INCLUDE path > problematically long). > > BUG=440500,584782 > > Committed: https://crrev.com/4c17ac0db59d7dbe78734950f83912ab564bd6fe > Cr-Commit-Position: refs/heads/master@{#373955} TBR=dpranke@chromium.org,scottmg@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440500,584782 Review URL: https://codereview.chromium.org/1678663002 Cr-Commit-Position: refs/heads/master@{#374013}
* Change default Windows compiler to VS 2015brucedawson2016-02-051-3/+1
| | | | | | | | | | | | | | | | | The change to get_landmines.py is there because modifying this file affects analyze behavior so that all tests run. Changing the printed message is purely a side effect. This change also removes some redundant INCLUDE paths. These are unnecessary when building with VS 2015 (because it defaults to the Windows 10 SDK) and actively harmful (they make the INCLUDE path problematically long). BUG=440500,584782 Review URL: https://codereview.chromium.org/1598493004 Cr-Commit-Position: refs/heads/master@{#373955}
* Revert of [Android] Add ChromiumNetTestSupport.apk for the java ↵danakj2015-12-151-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | EmbeddedTestServer. (patchset #13 id:240001 of https://codereview.chromium.org/1465383003/ ) Reason for revert: Android compile failing with related error: https://code.google.com/p/chromium/issues/detail?id=569991 Original issue's description: > [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer. > > BUG=488195 > > Committed: https://crrev.com/06215e9286247b08ff6c958f725c6e5185c4acd1 > Cr-Commit-Position: refs/heads/master@{#365254} TBR=tedchoc@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,mef@chromium.org,thakis@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488195 Review URL: https://codereview.chromium.org/1526183002 Cr-Commit-Position: refs/heads/master@{#365309}
* [Android] Add ChromiumNetTestSupport.apk for the java EmbeddedTestServer.jbudorick2015-12-151-0/+1
| | | | | | | | BUG=488195 Review URL: https://codereview.chromium.org/1465383003 Cr-Commit-Position: refs/heads/master@{#365254}
* Add landmine for libsqlite3.dylibluqui2015-09-021-0/+2
| | | | | | | | | | BUG=526208 NOTRY=true TBR=iannucci@chromium.org Review URL: https://codereview.chromium.org/1324943005 Cr-Commit-Position: refs/heads/master@{#346796}
* Convert ChromeSyncShell to use ChromePublic infrastructure (try #2)pvalenzuela2015-08-251-0/+2
| | | | | | | | | | | | | | | | | | This is a re-land of the patch originally committed as part of https://codereview.chromium.org/1282603005/. The one major change is that a landmine has been added to clobber the Android arm64 bot as it caused problems after the original commit. Several test fixes are included to support this change. Note: This CL only provides a GYP implementation (no GN). This is not a regression from the previous state. BUG=510211 Review URL: https://codereview.chromium.org/1305213003 Cr-Commit-Position: refs/heads/master@{#345392}
* Clobber to delete stale generated files.luqui2015-07-141-0/+2
| | | | | | | | | | BUG=510086 TBR=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1237223002 Cr-Commit-Position: refs/heads/master@{#338729}
* Prepare for VS2015 toolchainscottmg2015-06-021-0/+2
| | | | | | | | | | | | | | | This is not intended to change anything for current VS2013 users. The 2015 code here will not work until a change in depot_tools side lands. (It might not work after that either, but this is the first step in getting a 2015 fyi bot up.) R=dpranke@chromium.org BUG=492774 Review URL: https://codereview.chromium.org/1163723003 Cr-Commit-Position: refs/heads/master@{#332296}
* [RELAND] Fixit: Factor out common base::Time* math operator overloads.miu2015-05-101-0/+2
| | | | | | | | | | | | | | | | This relands https://codereview.chromium.org/1122443004 with a landmine to clobber the iOS builds. This is necessary because Xcode's logic for determining that base/time/time.h changed is faulty and is preventing modules dependent on it from being rebuilt. Revert history: https://codereview.chromium.org/1125283003 BUG=467417,485435 TBR=stuartmorgan@chromium.org Review URL: https://codereview.chromium.org/1131923005 Cr-Commit-Position: refs/heads/master@{#329060}
* Add a note that landmines should not be used in general.thakis2015-03-231-0/+6
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/1009603006 Cr-Commit-Position: refs/heads/master@{#321824}
* Roll NaCl toolchain change.ncbray2015-02-181-0/+1
| | | | | | | | | | | | | | | | This CL causes gclient runhooks to unpack the NaCl toolchain to //native_client/toolchain. It also causes GYP to use the toolchain from that location rather than unpacking it into the output directory during the build. This CL adds a landmine to reclaim ~1 GB of disk space. Landmines are normally used for correctness issues, in this case it is being used because an additional 1 GB of disk usage could cause random bots to fail. BUG=456902 Review URL: https://codereview.chromium.org/921243002 Cr-Commit-Position: refs/heads/master@{#316880}
* Upstream Enhanced Bookmark Model (2nd Land)ianwen2015-02-121-0/+1
| | | | | | | | | | | | | | This is the data layer of enhanced bookmark. There is no reason why this class should live in private repository. BUG=428832 Previously landed in: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261 Reverted in: https://crrev.com/f40cb64710a333da6d554e98dfcc432cd6cf8f1f Review URL: https://codereview.chromium.org/923653002 Cr-Commit-Position: refs/heads/master@{#316085}
* Revert of Upstream Enhanced Bookmark Model (patchset #6 id:100001 of ↵alexclarke2015-02-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/899403002/) Reason for revert: This is blocking downstream and people are complaining. I tried to land the downstream fix but there was a compile problem. Sorry, hope you can fix the problems and re-land. Original issue's description: > Upstream Enhanced Bookmark Model > > This is the data layout of enhanced bookmark. There is no reason why > this class should live in private repository. > > BUG=428832 > > Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261 > Cr-Commit-Position: refs/heads/master@{#315939} TBR=kkimlabs@chromium.org,newt@chromium.org,cjhopman@chromium.org,ianwen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428832 Review URL: https://codereview.chromium.org/920043003 Cr-Commit-Position: refs/heads/master@{#315976}
* Upstream Enhanced Bookmark Modelianwen2015-02-121-0/+1
| | | | | | | | | | | This is the data layout of enhanced bookmark. There is no reason why this class should live in private repository. BUG=428832 Review URL: https://codereview.chromium.org/899403002 Cr-Commit-Position: refs/heads/master@{#315939}
* Move //mojo/{public, edk} underneath //third_partyblundell2015-01-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | This CL move //mojo/public and //mojo/edk to live in the following locations: - //third_party/mojo/src/mojo/public - //third_party/mojo/src/mojo/edk It moves the related gypfiles from //mojo to //third_party/mojo and updates them as necessary to account for the file moves. It also updates clients of the mojo SDK and EDK targets in both GYP and GN. (Note that for GN, the mojo SDK and EDK build systems are maintained in the Mojo repo and designed to be flexible wrt the location of the SDK/EDK in a client repo, so no changes are needed. This CL does not update include paths to the code being moved to limit the number of moving parts, instead relying on the include_dirs that the SDK and EDK targets supply to their direct dependents to ensure that include paths continue to resolve correctly. NOPRESUBMIT=true Review URL: https://codereview.chromium.org/814543006 Cr-Commit-Position: refs/heads/master@{#312129}
* Revert of Reverting due to Android builders breakage. Subsequent fixes did ↵amistry2015-01-151-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not fix. (patchset #1 id:1 of https://codereview.chromium.org/843913006/) Reason for revert: Didn't fix the Android builders. Original issue's description: > Reverting due to Android builders breakage. Subsequent fixes did not fix. > > Revert "Use SuppressFBWarnings to suppress findbugs warnings" > > This reverts commit 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138. > > Revert "Temporarily add a workaround for findbugs." > > This reverts commit 790b64ba7f5343b6b99c97e8deaa635e1e9422d0. > > Revert "Temporarily remove some findbugs "known bugs"" > > This reverts commit 5a1c59272e7fd23116bcec8b952474e62bdcf7d3. > > NOTRY=true > TBR=cjhopman@chromium.org > > Committed: https://crrev.com/710d2f69b76e7b997307a7096e31029857e8c7fb > Cr-Commit-Position: refs/heads/master@{#311630} TBR=cjhopman@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/827123006 Cr-Commit-Position: refs/heads/master@{#311640}
* Reverting due to Android builders breakage. Subsequent fixes did not fix.amistry2015-01-151-1/+5
| | | | | | | | | | | | | | | | | | | | | Revert "Use SuppressFBWarnings to suppress findbugs warnings" This reverts commit 7ff0672b2a8c73be5a0164a04bc9c53f64f4b138. Revert "Temporarily add a workaround for findbugs." This reverts commit 790b64ba7f5343b6b99c97e8deaa635e1e9422d0. Revert "Temporarily remove some findbugs "known bugs"" This reverts commit 5a1c59272e7fd23116bcec8b952474e62bdcf7d3. NOTRY=true TBR=cjhopman@chromium.org Review URL: https://codereview.chromium.org/843913006 Cr-Commit-Position: refs/heads/master@{#311630}
* Use SuppressFBWarnings to suppress findbugs warningscjhopman2015-01-151-5/+1
| | | | | | | | | | | | | | | | | | This has several benefits: Makes the warning obvious at the place of the problem Makes suppressing the warnings the same as suppressing compiler and lint warnings Makes supporting findbugs as part of the build easier TBR=rmcilroy, mef, boliu BUG=431826 Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d Cr-Commit-Position: refs/heads/master@{#311402} Review URL: https://codereview.chromium.org/793203002 Cr-Commit-Position: refs/heads/master@{#311596}
* Add a landmine to clobber broken GN bots.Daniel Cheng2014-12-231-0/+1
| | | | | | | | | | | | GN bots are having trouble picking up the changes to the resouce ID range, which was changed in https://codereview.chromium.org/734243003/. BUG=444902 R=eroman@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/821303002 Cr-Commit-Position: refs/heads/master@{#309588}
* Out of line CallbackBase's copy and assignment operators.dcheng2014-11-261-0/+1
| | | | | | | | | | This saved nearly 300KiB on a release build of Chrome. BUG=436357 Review URL: https://codereview.chromium.org/760513002 Cr-Commit-Position: refs/heads/master@{#305784}
* Update to VS2013 Update 4, and Windows SDK 8.1scottmg2014-11-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | - Disable 4996 (deprecated functions in 8.1, these don't help us because we have to run on old OSs anyway) - Simplify Bluetooth LE header hacks (these headers are buggy in 8.0 and 8.1 SDKs, but less buggy in 8.1) - Revert attempt to centralize toolchain hashes as it didn't work well, and made it hard to roll anyway (see 400830). - Instead of basing C4702 (unreachable code) on Pro vs. Express, check whether it's actually disabled in the xtree header - Remove automatic calling of Express toolchain setup script. It hasn't worked well since post VS2013 RTM because of being distributed as .msp files, and the new Community edition is relatively easy to install so can subsume that usage (that being the motivation for the 4702 change above) - goma package for u4 is pushed - ANGLE is switched to load d3dcompiler_47 and build against 8.1 sdk, roll included here. Xrefs: - https://codereview.chromium.org/719343004/ - https://chromium-review.googlesource.com/#/c/229616/ - b2/18365241 - https://codereview.chromium.org/733563003/ - https://codereview.chromium.org/732673002/ - https://codereview.chromium.org/729453004/ - https://chromereviews.googleplex.com/120597013/ BUG=311488,432748,400830 Review URL: https://codereview.chromium.org/720033003 Cr-Commit-Position: refs/heads/master@{#304329}
* Add support to base::Timer for custom task runners.petrcermak2014-11-061-0/+1
| | | | | | | | | | | | | | | | | | This patch adds a public method SetTaskRunner(scoped_refptr<SingleThreadTaskRunner>) to base::Timer which changes the task runner used by the timer (ThreadTaskRunnerHandler::Get() by default). This change will enable scheduling timers on the queues of the Blink scheduler (see https://codereview.chromium.org/637303003/). Most importantly, we plan to apply this to the shared timer in blink::Platform. BUG= Review URL: https://codereview.chromium.org/637983003 Cr-Commit-Position: refs/heads/master@{#302947}
* Fix ninja "multiple rules" warning.petrcermak2014-10-301-0/+1
| | | | | | | | BUG=427526 Review URL: https://codereview.chromium.org/680923002 Cr-Commit-Position: refs/heads/master@{#302064}
* Reland Roll android_tools and breakpad to the latest.fdegans2014-10-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compared to the previous CL, this picks up in breakpad: Fix breakpad on mips and x86_64 for the NDK r10c update. Original issue's description: > Revert of Roll android_tools and breakpad to the latest. (patchset #5 id:80001 of https://codereview.chromium.org/671633003/) > > Reason for revert: > Downstream x64 and mips bots didn't like it. > > Original issue's description: > > Roll android_tools and breakpad to the latest. > > > > This picks up in android_tools: > > Updated SDK build tools to 21.0.1 and removed old versions. > > Upgrade NDK to r10c. > > > > And in breakpad: > > Update breakpad to support Android NDK r10c > > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. > > Refactor .so name detection logic in minidump/linux_dumper. > > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. > > Linux multiprocess crash reporter: use pipe instead of socketpair in the client. > > Remove workaround for Linux credential-passing bug. > > > > TBR=brettw, danakj > > NOTRY=true > > BUG=424680, 425077, 358831 > > > > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b > > Cr-Commit-Position: refs/heads/master@{#300671} > > TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=424680, 425077, 358831 > > Committed: https://crrev.com/e6319d7f7d5c2fc96c9cb1f5a81ae16bde19f068 > Cr-Commit-Position: refs/heads/master@{#300688} TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,ppi@chromium.org BUG=424680, 425077, 358831 Review URL: https://codereview.chromium.org/676483002 Cr-Commit-Position: refs/heads/master@{#301087}
* Final step of the java_cpp_template -> java_cpp_enum migration.mkosiba2014-10-231-2/+1
| | | | | | | | | | | This CL migrates the remaining gyp/gn rules away from the java_cpp_template rule. BUG=405532 Review URL: https://codereview.chromium.org/659493003 Cr-Commit-Position: refs/heads/master@{#300881}
* Revert of Roll android_tools and breakpad to the latest. (patchset #5 ↵ppi2014-10-221-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:80001 of https://codereview.chromium.org/671633003/) Reason for revert: Downstream x64 and mips bots didn't like it. Original issue's description: > Roll android_tools and breakpad to the latest. > > This picks up in android_tools: > Updated SDK build tools to 21.0.1 and removed old versions. > Upgrade NDK to r10c. > > And in breakpad: > Update breakpad to support Android NDK r10c > Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. > Refactor .so name detection logic in minidump/linux_dumper. > The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. > Linux multiprocess crash reporter: use pipe instead of socketpair in the client. > Remove workaround for Linux credential-passing bug. > > TBR=brettw, danakj > NOTRY=true > BUG=424680, 425077, 358831 > > Committed: https://crrev.com/79bd5f12620f81dd241984d925b87a888e1dc37b > Cr-Commit-Position: refs/heads/master@{#300671} TBR=brettw@chromium.org,primiano@chromium.org,rmcilroy@chromium.org,aurimas@chromium.org,danakj@chromium.org,fdegans@chromium.org NOTREECHECKS=true NOTRY=true BUG=424680, 425077, 358831 Review URL: https://codereview.chromium.org/676453002 Cr-Commit-Position: refs/heads/master@{#300688}
* Roll android_tools and breakpad to the latest.fdegans2014-10-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | This picks up in android_tools: Updated SDK build tools to 21.0.1 and removed old versions. Upgrade NDK to r10c. And in breakpad: Update breakpad to support Android NDK r10c Fixing the Mac Inspector build by adding the launch_report dependency to the breakpadUtilities dylib project after it got pulled out from Inspector.mm. Refactor .so name detection logic in minidump/linux_dumper. The process uptime computation when the Windows out-of-process Crash Generation Server is used is done by subtracting the crashing process creation time from the current time when the crash is generated. Linux multiprocess crash reporter: use pipe instead of socketpair in the client. Remove workaround for Linux credential-passing bug. TBR=brettw, danakj NOTRY=true BUG=424680, 425077, 358831 Review URL: https://codereview.chromium.org/671633003 Cr-Commit-Position: refs/heads/master@{#300671}
* Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 ↵skyostil2014-10-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/625543002/) Reason for revert: Oops, wasn't supposed to revert this after all. Original issue's description: > Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/) > > Reason for revert: > Fails to compile on several bots: > > https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio > > First error: > FAILED: cd ../../clank/native/framework; python <snip ...> > ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol > import org.chromium.content.common.TopControlsState; > ^ > symbol: class TopControlsState > location: package org.chromium.content.common > > Original issue's description: > > Use the new java_cpp_enum rule in content. > > > > This moves most of the generated Java enums under content/ to use the > > java_cpp_enum rule removing the need for keeping the enums in > > separate list files and the need for the .template files. > > > > BUG=405532, 351558 > > > > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96 > > Cr-Commit-Position: refs/heads/master@{#297789} > > TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=405532, 351558 > > Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef > Cr-Commit-Position: refs/heads/master@{#297793} TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org NOTREECHECKS=true NOTRY=true BUG=405532, 351558 Review URL: https://codereview.chromium.org/617103007 Cr-Commit-Position: refs/heads/master@{#297794}
* Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 ↵perezju2014-10-021-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/615893003/) Reason for revert: Fails to compile on several bots: https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio First error: FAILED: cd ../../clank/native/framework; python <snip ...> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol import org.chromium.content.common.TopControlsState; ^ symbol: class TopControlsState location: package org.chromium.content.common Original issue's description: > Use the new java_cpp_enum rule in content. > > This moves most of the generated Java enums under content/ to use the > java_cpp_enum rule removing the need for keeping the enums in > separate list files and the need for the .template files. > > BUG=405532, 351558 > > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96 > Cr-Commit-Position: refs/heads/master@{#297789} TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org NOTREECHECKS=true NOTRY=true BUG=405532, 351558 Review URL: https://codereview.chromium.org/625543002 Cr-Commit-Position: refs/heads/master@{#297793}
* Use the new java_cpp_enum rule in content.mkosiba2014-10-021-0/+1
| | | | | | | | | | | | This moves most of the generated Java enums under content/ to use the java_cpp_enum rule removing the need for keeping the enums in separate list files and the need for the .template files. BUG=405532, 351558 Review URL: https://codereview.chromium.org/615893003 Cr-Commit-Position: refs/heads/master@{#297789}
* Use the new java_cpp_enum rule in net.mkosiba2014-09-301-0/+2
| | | | | | | | | | | | This moves most of the generated Java enums under net/ to use the java_cpp_enum rule removing the need for keeping the enums in separate list files and the need for the .template files. BUG=405532 Review URL: https://codereview.chromium.org/599493004 Cr-Commit-Position: refs/heads/master@{#297420}
* mojo: Fix java generatorqsr2014-09-291-1/+1
| | | | | | | | | | | Fix issue with method with empty response. Fix issue with local variable shadowing user parameters. R=ppi@chromium.org Review URL: https://codereview.chromium.org/607933002 Cr-Commit-Position: refs/heads/master@{#297176}
* Add a landmine for crbug.com/408192Nico Weber2014-09-021-0/+1
| | | | | | | | TBR=jam@chromium.org Review URL: https://codereview.chromium.org/529183004 Cr-Commit-Position: refs/heads/master@{#293024}
* mojo: generate Proxies and Stubs for java bindings.qsr2014-08-271-1/+1
| | | | | | | | | | | This CL allows to generate Stub and Proxy of mojo service in java. This allows to call interfaces method through message pipes. Committed: https://chromium.googlesource.com/chromium/src/+/b2ef91ee4abe584e712db7a51d47a1b6d9a96e57 Review URL: https://codereview.chromium.org/411913002 Cr-Commit-Position: refs/heads/master@{#292154}
* Revert 289650 "Roll buildtools, this updates VS2013 Pro to Update 3"scottmg@chromium.org2014-08-151-1/+0
| | | | | | | | | | | | | | | | | | | | | gfx_unittests fails on x64_rel. Unclear why tryjob was successful, perhaps different hardware between tryjob and waterfall. > Roll buildtools, this updates VS2013 Pro to Update 3 > > TBR=iannucci@chromium.org > NOTRY=true > BUG=402543 > > Review URL: https://codereview.chromium.org/458353003 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/477013002 Cr-Commit-Position: refs/heads/master@{#289729} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289729 0039d316-1c4b-4281-b951-d872f2087c98
* Roll buildtools, this updates VS2013 Pro to Update 3scottmg@chromium.org2014-08-141-0/+1
| | | | | | | | | | | TBR=iannucci@chromium.org NOTRY=true BUG=402543 Review URL: https://codereview.chromium.org/458353003 Cr-Commit-Position: refs/heads/master@{#289650} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289650 0039d316-1c4b-4281-b951-d872f2087c98
* Make landmines work on local builds tooscottmg@chromium.org2014-08-141-13/+2
| | | | | | | | | | | | | | | | | | | | | Moves (some of) gyp environment setup out of gyp_chromium into separate module, and shares that between gyp_chromium and landmines.py. landmines.py is added as the first entry in DEPS hooks so that it can clobber the entire build directory before running other hooks that extract/generate into the build dir. Reland with fix for ios, and for clean pull. R=iannucci@chromium.org BUG=400011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099 Review URL: https://codereview.chromium.org/457003004 Cr-Commit-Position: refs/heads/master@{#289546} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289546 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Make landmines work on local builds too (patchset #3 of ↵iannucci@chromium.org2014-08-131-2/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/457003004/) Reason for revert: Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build): Traceback (most recent call last): File "src/build/landmines.py", line 132, in <module> sys.exit(main()) File "src/build/landmines.py", line 119, in main gyp_environment.SetEnvironment() File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs() File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs with open(json_data_file, 'r') as tempf: IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json' Original issue's description: > Make landmines work on local builds too > > Moves (some of) gyp environment setup out of gyp_chromium into separate > module, and shares that between gyp_chromium and landmines.py. > > landmines.py is added as the first entry in DEPS hooks so that it can > clobber the entire build directory before running other hooks that > extract/generate into the build dir. > > R=iannucci@chromium.org > BUG=400011 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099 TBR=scottmg@chromium.org NOTREECHECKS=true NOTRY=true BUG=400011 Review URL: https://codereview.chromium.org/469623002 Cr-Commit-Position: refs/heads/master@{#289158} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289158 0039d316-1c4b-4281-b951-d872f2087c98
* Make landmines work on local builds tooscottmg@chromium.org2014-08-121-13/+2
| | | | | | | | | | | | | | | | | Moves (some of) gyp environment setup out of gyp_chromium into separate module, and shares that between gyp_chromium and landmines.py. landmines.py is added as the first entry in DEPS hooks so that it can clobber the entire build directory before running other hooks that extract/generate into the build dir. R=iannucci@chromium.org BUG=400011 Review URL: https://codereview.chromium.org/457003004 Cr-Commit-Position: refs/heads/master@{#289099} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289099 0039d316-1c4b-4281-b951-d872f2087c98
* Update lint and findbugs to use jars instead of class filescjhopman@chromium.org2014-08-121-2/+1
| | | | | | | | | | Now that this is done, we don't need to leave the class files laying around anymore. So don't. Review URL: https://codereview.chromium.org/458653002 Cr-Commit-Position: refs/heads/master@{#288971} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288971 0039d316-1c4b-4281-b951-d872f2087c98
* Add a landmine to fix builders after blink_resources.grd changedeseidel@chromium.org2014-08-051-0/+1
| | | | | | | | | | | I will send a PSA to chromium-dev shortly explaining the issue. BUG=338338, 400860 NOTRY=true Review URL: https://codereview.chromium.org/441133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287640 0039d316-1c4b-4281-b951-d872f2087c98
* Add a landmine for the content/child/blink_platform_impl.cc IDR_* errors.thakis@chromium.org2014-08-011-0/+1
| | | | | | | | | BUG=338338 NOTRY=true Review URL: https://codereview.chromium.org/439503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287102 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-05-17 10:54:08 +0000