| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deletes the forwarding headers in base/prefs.
Updates the remaining users of base/prefs includes to use components/prefs.
Sort headers in updated files.
Move PrefServiceFactory out of the base namespace. Update users.
Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
COMPONENTS_PREFS_.
Add components/prefs to DEPS file of directories where checkdeps fails after
the update.
BUG=583034
Reland of http://crrev.com/1662523004#ps40001 with fix.
TBR=estade@chromium.org
Review URL: https://codereview.chromium.org/1668463002
Cr-Commit-Position: refs/heads/master@{#373197}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#3 id:40001 of https://codereview.chromium.org/1662523004/ )
Reason for revert:
Broke Win Builder compile:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio
Original issue's description:
> Delete base/prefs and update callers to use components.
>
> Deletes the forwarding headers in base/prefs.
>
> Updates the remaining users of base/prefs includes to use components/prefs.
> Sort headers in updated files.
>
> Move PrefServiceFactory out of the base namespace. Update users.
>
> Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
> COMPONENTS_PREFS_.
>
> Add components/prefs to DEPS file of directories where checkdeps fails after
> the update.
>
> BUG=583034
>
> Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef
> Cr-Commit-Position: refs/heads/master@{#373105}
TBR=estade@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583034
Review URL: https://codereview.chromium.org/1662843002
Cr-Commit-Position: refs/heads/master@{#373115}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Deletes the forwarding headers in base/prefs.
Updates the remaining users of base/prefs includes to use components/prefs.
Sort headers in updated files.
Move PrefServiceFactory out of the base namespace. Update users.
Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
COMPONENTS_PREFS_.
Add components/prefs to DEPS file of directories where checkdeps fails after
the update.
BUG=583034
Review URL: https://codereview.chromium.org/1662523004
Cr-Commit-Position: refs/heads/master@{#373105}
|
|
|
|
|
|
|
|
|
| |
BUG=None
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1410053006
Cr-Commit-Position: refs/heads/master@{#359461}
|
|
|
|
|
|
|
|
| |
BUG=492669
Review URL: https://codereview.chromium.org/1160683004
Cr-Commit-Position: refs/heads/master@{#331958}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In addition to moving the browser-side of the GuestView layer into components, this CL also:
1. Replaces some loops to the top level web contents with GuestViewBase::GetTopLevelWebContents.
2. Installs the ExtensionsGuestViewMessageFilter in appshell.
3. Move some files out of extensions/common/guest_view to components/guest_view/common
BUG=444869
Review URL: https://codereview.chromium.org/1102173002
Cr-Commit-Position: refs/heads/master@{#328243}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows 8+ with AppContainer prote… (patchset #14 id:260001 of https://codereview.chromium.org/1105763004/)
Reason for revert:
This patch causes a perf regression bug during renderer startup which is triggered when the cache is not available. Will send out a new patch which addresses both issues.
The perf bug is here:-
https://code.google.com/p/chromium/issues/detail?id=483443
Original issue's description:
> Ensure that the DirectWrite font cache works in Chrome canary on Windows 8+ with AppContainer protection.
>
> The DirectWrite font cache is mapped as a shared section by the renderer processes. The browser creates
> the section. On Windows 8+ with AppContainer protection the renderers are unable to open this shared section
> as the BaseNamedObjects object directory is virtualized to \Sessions\SessionId\AppContainerNamedObjects.
>
> This effectively means that the renderers now fallback to the old method of enumerating all fonts while DirectWrite
> builds up its font cache. This hurts performance.
>
> Proposed fix is as below :-
> 1. When the renderer process is launched we get notified in the RenderProcessHost::OnProcessLaunched method.
> We send a control IPC message here ViewMsg_FontCacheSectionHandle which contains the duplicated font cache
> section handle.
>
> 2. The ViewMsg_FontCacheSectionHandle message is handled by RenderThreadImpl. It ensures that the shared handle
> is set by calling a helper function SetFontCacheSectionHandle. This function then triggers the setting of the
> DirectWrite font factory in skia.
>
> 3. Some of the code in the WarmupDirectWrite function is no longer needed like the code to create the font factory
> and create some fonts to warm up DirectWrite. This is because DirectWrite in the renderer now uses the custom
> font collection which means that most of the code now can run in the sandbox. The only parts which need to run
> outside the sandbox are the loading of the dwrite.dll and the code in the FontCollectionLoader which reads fonts
> from the registry.
>
> 4. The GetPreSandboxWarmupFontMgr helper function has been renamed to GetDirectWriteFontManager.
>
> The UMA metric DirectWrite.Fonts.LoadTime.Cached should be available if the font cache is loaded in the renderer.
>
> BUG=481285
> R=cpu
>
> Committed: https://crrev.com/bbca53aa082320e13909d995a9af66bed7de69a8
> Cr-Commit-Position: refs/heads/master@{#327804}
TBR=cpu@chromium.org,scottmg@chromium.org,shrikant@chromium.org,scheib@chromium.org,palmer@chromium.org,piman@chromium.org,creis@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=481285
Review URL: https://codereview.chromium.org/1127673002
Cr-Commit-Position: refs/heads/master@{#328160}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with AppContainer protection.
The DirectWrite font cache is mapped as a shared section by the renderer processes. The browser creates
the section. On Windows 8+ with AppContainer protection the renderers are unable to open this shared section
as the BaseNamedObjects object directory is virtualized to \Sessions\SessionId\AppContainerNamedObjects.
This effectively means that the renderers now fallback to the old method of enumerating all fonts while DirectWrite
builds up its font cache. This hurts performance.
Proposed fix is as below :-
1. When the renderer process is launched we get notified in the RenderProcessHost::OnProcessLaunched method.
We send a control IPC message here ViewMsg_FontCacheSectionHandle which contains the duplicated font cache
section handle.
2. The ViewMsg_FontCacheSectionHandle message is handled by RenderThreadImpl. It ensures that the shared handle
is set by calling a helper function SetFontCacheSectionHandle. This function then triggers the setting of the
DirectWrite font factory in skia.
3. Some of the code in the WarmupDirectWrite function is no longer needed like the code to create the font factory
and create some fonts to warm up DirectWrite. This is because DirectWrite in the renderer now uses the custom
font collection which means that most of the code now can run in the sandbox. The only parts which need to run
outside the sandbox are the loading of the dwrite.dll and the code in the FontCollectionLoader which reads fonts
from the registry.
4. The GetPreSandboxWarmupFontMgr helper function has been renamed to GetDirectWriteFontManager.
The UMA metric DirectWrite.Fonts.LoadTime.Cached should be available if the font cache is loaded in the renderer.
BUG=481285
R=cpu
Review URL: https://codereview.chromium.org/1105763004
Cr-Commit-Position: refs/heads/master@{#327804}
|
|
|
|
|
|
|
|
|
|
|
| |
since browsing_data/ is now under components/
BUG=471287
Test=None, internal only change without visible side effects.
Review URL: https://codereview.chromium.org/1056793002
Cr-Commit-Position: refs/heads/master@{#326985}
|
|
|
|
|
|
|
|
|
|
|
| |
This is a mostly mechanical change to move these files over, and
make corresponding changes to strings, build files, and include paths.
BUG=447014
Review URL: https://codereview.chromium.org/864093002
Cr-Commit-Position: refs/heads/master@{#313404}
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a followup to the move of the Mojo SDK and EDK to live under //third_party,
this CL updates Chromium code to include SDK/EDK headers via fully-qualified
paths instead of relying on include_dirs that are exported by the Mojo targets.
This CL also includes mechanical updates to DEPS files to satisfy checkdeps.
Review URL: https://codereview.chromium.org/846443006
Cr-Commit-Position: refs/heads/master@{#312858}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently these tests are utilizing the content::RenderViewTest as the base class
whereas all other *_browsertest.cc are using ChromeRenderViewTest as the base class.
Due to this, the migration of inline CSS to GRD being done in [1] is failing
for browsertests target as listed here [2] in the build log.
In order to fix this, these tests should use the ChromeRenderViewTest as their base class.
In doing so, the ChromeRenderViewTest loads ChromeContentClient which in turn loads the correct
pak file i.e. resources.pak required for the migration.
This CL adds the extensions/DEPS rule to allow the inclusion of chrome_render_view_test.h.
[1] https://codereview.chromium.org/573553002
[2] http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14184
Review URL: https://codereview.chromium.org/818563003
Cr-Commit-Position: refs/heads/master@{#309424}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does a few things. Firstly, it stops bookmark apps from
using downloaded favicons / manifest icons. Secondly, it syncs the
color it uses to generate icons. Thirdly, machines that bookmark apps
are synced onto will now generate icons using the synced color.
This means bookmark apps will always have nice icons (although not the
ones downloaded) and they will always be consistent across machines.
Once blob sync is available the downloaded icons will be kept and
synced.
BUG=439347
Review URL: https://codereview.chromium.org/782693002
Cr-Commit-Position: refs/heads/master@{#307889}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove some unnecessary DEPS in the test section.
BUG=none
TEST=passes checkdeps.py
Review URL: https://codereview.chromium.org/750813002
Cr-Commit-Position: refs/heads/master@{#305379}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch makes more explicit the set of dependencies
allowed from //extensions onto //ui.
//extensions was allowing dependencies on all of //ui
by default. This is unfortunate for people who want to
introduce new code into //extensions only to be shot
down because they depend on pieces of ui that aren't
allowed.
BUG=None
Review URL: https://codereview.chromium.org/702513002
Cr-Commit-Position: refs/heads/master@{#302637}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's currently a dependency cycle between gyp files: components.gyp
and extensions.gyp. extensions.gyp depends on a number of components,
and two components depend on exetensions.gyp. These are:
- components/renderer_context_menu/
- components/native_app_window/ (more recently)
renderer_context_menu has an "optional" extensions dependency, which can
be skipped when ENABLE_EXTENSIONS is not defined. Still, it is necessary
for renderer_context_menu.gyp to omit its extensions.gyp dependency and
build as a static library.
For native_app_window, since it is not compiled on Mac, the gyp circular
check is not performed on the bots.
This CL fixes the layering by adding a folder,
src/extensions/components. Things here may depend on extensions, but not
on other extensions/components folders in a way that creates a cycle.
This also allows the benefits of a component-architecture to make sense
of interdependencies between the ~1337 files under src/extensions.
This layout also makes it clear that by depending on one of these
components, a target is also depending on src/extensions. Currently,
this is not clear.
BUG=35878, 418455
TBR=reed@google.com
Review URL: https://codereview.chromium.org/606953002
Cr-Commit-Position: refs/heads/master@{#297952}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They don't need to run in Chrome's unit_tests suite.
* Move FileHandlersManifestTest
* Move ExternallyConnectableManifestTest
* Migrate some _manifest_features.json entries that should have been under
src/extensions a while ago.
BUG=397165
TEST=extensions_unittests, unit_tests
Review URL: https://codereview.chromium.org/565423003
Cr-Commit-Position: refs/heads/master@{#295479}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL broke the Win official bots because they report their default
version channel as "canary" instead of "trunk".
https://codereview.chromium.org/572813002
Original description:
This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.
* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.
FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).
BUG=397165
TEST=unit_tests, extensions_unittests
TBR=rockot@chromium.org
Review URL: https://codereview.chromium.org/574173002
Cr-Commit-Position: refs/heads/master@{#295225}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.
Original CL:
Refactor ExtensionManifestTest to allow usage in src/extensions
https://codereview.chromium.org/572813002
Reason:
Broke the official Win builders due to differences in how they report their
version channel.
http://master.chrome.corp.google.com:8011/builders/win%20trunk/builds/26150
BUG=414917
TEST=unit_tests
TBR=rockot@chromium.org
Review URL: https://codereview.chromium.org/578653005
Cr-Commit-Position: refs/heads/master@{#295172}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.
* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.
FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).
BUG=397165
TEST=unit_tests, extensions_unittests
Review URL: https://codereview.chromium.org/572813002
Cr-Commit-Position: refs/heads/master@{#295087}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move socket_permission_unittest.cc and usb_device_permission_unittest.cc
into src/extensions -- they have no src/chrome dependencies.
* Move permissions_data_unittest.cc back into src/chrome -- its tests rely on
extension manifest keys that aren't part of src/extensions yet.
* Rename the latter tests to PermissionsDataTest
BUG=397165
TEST=unit_tests PermissionsDataTest.* and extensions_unittests
Review URL: https://codereview.chromium.org/563663002
Cr-Commit-Position: refs/heads/master@{#294493}
|
|
|
|
|
|
|
|
| |
BUG=388893
Review URL: https://codereview.chromium.org/555633003
Cr-Commit-Position: refs/heads/master@{#294031}
|
|
|
|
|
|
|
|
|
| |
BUG=395240
TBR=keybuk@chromium.org
Review URL: https://codereview.chromium.org/420663003
Cr-Commit-Position: refs/heads/master@{#292719}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The source file changes were done using:
for f in $(git grep -l '"grit/content_resources.h"' -- '*.cc' '*.mm'); do
sed -i -e 's/"grit\/content_resources.h"/"content\/grit\/content_resources.h"/' $f ;
done
tools/git/for-all-touched-files.py -c "tools/sort-headers.py -f [[FILENAME]]"
The gyp, gn, and DEPS changes were lovingly hand-crafted.
BUG=401588
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/492813002
Cr-Commit-Position: refs/heads/master@{#290896}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move AppDelegate, AppWebContentsHelper and AppWindowGeometryCache to extensions/browser/app_window
Change the namespace from apps to extensions.
BUG=403726
R=benwells@chromium.org
Review URL: https://codereview.chromium.org/486153002
Cr-Commit-Position: refs/heads/master@{#290796}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CRX file code currently lives under extensions/. However,
component_updater also uses them to package components. The
CRX code should therefore live as its own component.
BUG=371463
TBR=blundell@chromium.org
Review URL: https://codereview.chromium.org/474633005
Cr-Commit-Position: refs/heads/master@{#289966}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the extensions module refactor we temporarily allowed the use
of chrome_notification_types.h in src/extensions. However, this allowed
code moving into src/extensions to listen to notifications from Chrome,
which was a layering violation.
This CL moves all the extensions notifications into their own header and
cleans up DEPS to disallow the exception.
BUG=392622
TEST=compiles, unit_tests, browser_tests, extensions_unittests
TBR=miket@chromium.org for apps/
Review URL: https://codereview.chromium.org/425303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds the infrastructure for unit testing the JS parts of
apps and extensions APIs implemented on top of Mojo services. The test
environment provides a partial implementation of the JS test API
provided to browser tests. A TestServiceProvider implementation is
used to provide test implementations of the appropriate Mojo services to
the JS code.
BUG=389016
Review URL: https://codereview.chromium.org/399363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This does:
- Move files
- Fix up all namespaces in these files to be extensions, not apps
- Clean up DEPS files
This does not:
- Change the name of the build targets (app_shell, app_shell_browsertests)
BUG=394987
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/412713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support
deferred loading of extension background pages when the profile isn't ready
yet. This is a layering violation.
* Remove Chrome concepts like "browser window ready" and "profile created"
from ProcessManager. Introduce ProcessManagerDelegate with a general concept
of deferring background page loading.
* Consolidate all the tricky Chrome-specific background page loading rules into
ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate
each block of special case code with the bug that inspired it.
* Extend unit test coverage for ProcessManager.
This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED
in ProcessManager in a later CL.
(Original CL https://codereview.chromium.org/381283002 broke valgrind bots
because it was initializing left-over BrowserContextKeyedServices from tests
running earlier in the same process.)
BUG=392658
TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
Review URL: https://codereview.chromium.org/408523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke Chrome OS valgrind bots, for example:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/27033
> Refactor code that defers extension background page loading
>
> src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.
>
> * Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
> * Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
> * Extend unit test coverage for ProcessManager.
>
> This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.
>
> BUG=392658
> TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
>
> Review URL: https://codereview.chromium.org/381283002
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/399153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/extensions depends on chrome::NOTIFICATION_PROFILE_CREATED to support deferred loading of extension background pages when the profile isn't ready yet. This is a layering violation.
* Remove Chrome concepts like "browser window ready" and "profile created" from ProcessManager. Introduce ProcessManagerDelegate with a general concept of deferring background page loading.
* Consolidate all the tricky Chrome-specific background page loading rules into ChromeProcessManagerDelegate. This keeps all the rules in one place. Annotate each block of special case code with the bug that inspired it.
* Extend unit test coverage for ProcessManager.
This will make it easier to eliminate chrome::NOTIFICATION_PROFILE_DESTROYED in ProcessManager in a later CL.
BUG=392658
TEST=unit_tests ProcessManagerTest, browser_tests ProcessManagerBrowserTest, manual
Review URL: https://codereview.chromium.org/381283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=389348
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/363993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And use it from c/e/b/extensions/.
BUG=354046
R=yoz@chromium.org, thestig@chromium.org, kalman@chromium.org
TEST=browser_tests
Review URL: https://codereview.chromium.org/334083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step in refactoring the (overly-gigantic)
extension_service_unittest.cc
BUG=381251
TBR=atwilson@chromium.org (c/b/background/)
TBR=bauerb@chromium.org (c/b/managed_mode/)
TBR=battre@chromium.org (c/b/profile_resetter/)
TBR=pkotwicz@chromium.org (c/b/themes)
TBR=koz@chromium.org (c/b/ui/app_list)
All TBRs are for simple mechanical changes (primarily namespace move).
Review URL: https://codereview.chromium.org/318863008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions_renderer_resources.grd.
This patch fixes references in the .gyp to .js resource files (again).
This breaks the remaining dependency from src/extensions to chrome resources files.
BUG=368334
TBR=rockot@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/312213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions_renderer_resources.grd."
This reverts commit 43d0610ab216be636ccd80fe42ed338c326a6d81.
Broke Win build: http://build.chromium.org/p/chromium/builders/Win/builds/21536
BUG=none
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/318683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extensions_renderer_resources.grd.
This patch fixes references in the .gyp to .js resource files.
This breaks the remaining dependency from src/extensions to chrome resources files.
BUG=368334
TBR=rockot@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/312883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke various builds (http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/54738/steps/runhooks/logs/stdio for example) since chrome_renderer.gypi (and maybe other files) still have refernces to the old location of these resources.
> Move some extensions renderer resources to extensions_renderer_resources.grd.
>
> This breaks the remaining dependency from src/extensions to chrome resources files.
>
> BUG=368334
>
> Review URL: https://codereview.chromium.org/307833002
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/309413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This breaks the remaining dependency from src/extensions to chrome resources files.
BUG=368334
Review URL: https://codereview.chromium.org/307833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=368334
Review URL: https://codereview.chromium.org/296133011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
feature sources.
This makes TestFeaturesNativeHandler less Chrome-specific.
Also add more const to FeatureProvider.
Remove common_resources.h from extensions DEPS.
BUG=368334
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/293943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the runtime API schema and implementation to //extensions,
offloading some of its responsibilities out to a new RuntimeAPIDelegate
provided by the active ExtensionsBrowserClient.
BUG=369391
TBR=derat for mechanical chromeos changes
TBR=tzik for +webkit/browser/fileapi to extensions/browser/DEPS
TBR=sky for new chrome/test dependency
Review URL: https://codereview.chromium.org/264743014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the chrome.usb API implementation into the
core set of extensions APIs.
BUG=369391
R=rpaquay
TBR=yoz for extensions
TBR=sky for +chrome/browser/ui in test DEPS
Review URL: https://codereview.chromium.org/268713013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks another //extensions -> //chrome circular dependency.
* Split out Chrome-specific parts of ExtensionHelper to ChromeExtensionHelper
* Move ExtensionHelper to //extensions
* Move UserScriptScheduler to //extensions (a dependency of ExtensionHelper)
* Tighten DEPS
BUG=162530
TEST=compiles, existing browser_tests
TBR=bbudge@chromium.org for mechanical header file move touching chrome/renderer/pepper
Review URL: https://codereview.chromium.org/261733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves Dispatcher into //extensions along with
several of its remaining dependencies.
This also introduces a DispatcherDelegate interface along with implementations for chrome and app_shell.
BUG=359836
TBR=sky for CCRC and ChromeRenderViewTest
Review URL: https://codereview.chromium.org/260083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move GetDefaultAppIcon and GetDefaultExtensionIcon out of src/extensions
into chrome/browser.
* Inline one call to GetDefaultAppIcon in src/apps
This requires a DEPS exception in src/apps for grit/theme_resources.h, but
that's better than having one in src/extensions (as src/apps is much higher
in the dependency tree).
No functional changes.
BUG=368334
TEST=Clean build of extensions_unittests succeeds, Chrome about:extensions still displays default icon for extension with no icon.
TBR=msw@chromium.org for mechanical namespace/include changes in chrome/browser/ui/views/
Review URL: https://codereview.chromium.org/259343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extract extensions-module strings into their own .grd and .gyp file.
Follows the conventions of components_strings.gyp and ui_strings.gyp.
Starts by moving sockets API strings, more will follow.
BUG=335157
TEST=compiles, unit_tests *Extension*
TBR=mmoss@chromium.org for chrome/tools/build/repack_locales.py
TBR=thomasvl@chromium.org for chrome/tools/check_grd_for_unused_strings.py
Review URL: https://codereview.chromium.org/239543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also moves ModuleSystem, RequestSender,
ObjectBackedNativeHandler, and SafeBuiltins
over to //extensions.
Other renderer code is updated minimally to support
these changes.
BUG=359836
TBR=sky@chromium.org for chrome/test
TBR=jamescook@chromium.org for apps/shell
TBR=maruel@chromium.org for PRESUBMIT.py
Review URL: https://codereview.chromium.org/234413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existence of stable/beta/dev channel is a Chrome concept. Eliminate the reference to feature_channel.h in //extensions by observing for renderer startup and sending the channel to the renderer in //chrome.
This is also one of our last //extensions -> //chrome circular dependencies.
BUG=362244
TEST=browser_tests *Extensions*
Review URL: https://codereview.chromium.org/234183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263314 0039d316-1c4b-4281-b951-d872f2087c98
|