summaryrefslogtreecommitdiffstats
path: root/extensions/browser/api
Commit message (Collapse)AuthorAgeFilesLines
* Move base::FreeDeleter into its own header.dcheng2016-03-261-0/+1
| | | | | | | | | | Final blocker to wholly deleting base/memory/scoped_ptr.h. BUG=554298 Review URL: https://codereview.chromium.org/1837483003 Cr-Commit-Position: refs/heads/master@{#383417}
* Extensions: Using common ValueStoreFactory for all value stores.cmumford2016-03-2416-232/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | 1. Introduce new ValueStoreFactory interface used for the creation of ValueStore's in all namespaces (local, sync, and managed), and for all types (extension and application). 2. Delete SettingsStorageFactory/LeveldbSettingsStorageFactory, and switched to ValueStoreFactory. 3. Created a new TestValueStoreFactory (for testing). This combines settings_sync_unittest.cc:TestingValueStoreFactory and ScopedSettingsStorageFactory. 4. ValueStoreFrontend::Backend always lazilily initializes using the ValueStoreFactory. This makes unnecessary StateStore's deferred initialization mechanism - which will be removed in an upcoming CL. 5. A new ValueStoreFactoryImpl to mint new ValueStore's for Chrome. This currently delegates to a new LegacyValueStoreFactory which creates new LeveldbValueStore. An upcoming CL will add a second delegated factory (currently called ProfileValueStoreFactory) to support a unified (per-profile) extensions database. 6. Removed memcheck suppression for SettingsStorageFactory as this class is now deleted (crbug.com/163922). BUG=453946,163922 Review URL: https://codereview.chromium.org/1803193002 Cr-Commit-Position: refs/heads/master@{#383137}
* Fix assertion at extensions::DisplaySourceConnectionDelegateFactorymaksim.sisov2016-03-231-1/+1
| | | | | | | | | The DisplaySourceConnectionDelegateFactory::BuildServiceInstanceFor method is actually invoked on UI thread. Review URL: https://codereview.chromium.org/1824793004 Cr-Commit-Position: refs/heads/master@{#382817}
* Add RetainedRef uses where needed.vmpstr2016-03-211-1/+1
| | | | | | | | | | | | | | | This patch adds RetainedRef uses where they are required. These changes will be required when we remove automatic unwrapping of scoped_refptrs in Bind. Please see the bug for more context. R=tzik@chromium.org, thakis@chromium.org, danakj@chromium.org BUG=589048 Review URL: https://codereview.chromium.org/1815363002 Cr-Commit-Position: refs/heads/master@{#382371}
* Extend vpnProvider to allow reconnectionscernekee2016-03-162-2/+12
| | | | | | | | | | | | | | | | | | Upcoming changes in the Chrome OS networking daemon (shill) will allow third party VPNs to transition "backwards" from Online->Configuring if the default physical connection changes. Add a "reconnect" flag so that VPN apps can signal their compatibility with this new scheme, and add the necessary UI changes so that Chrome can identify reconnections and present them to the user in a sensible way. Also, change the UI so that users can cancel VPN reconnections (and connections) using the "Disconnect" button. BUG=514343 Review URL: https://codereview.chromium.org/1722453002 Cr-Commit-Position: refs/heads/master@{#381566}
* Invoke createNetwork() callback with GUID, not service namecernekee2016-03-153-3/+13
| | | | | | | | | | | | | | The current implementation doesn't match the API spec. Fix this. BUG=593196 TEST=go to chrome://settings/network , ctrl-shift-i, run in console: chrome.networkingPrivate.createNetwork(false, {"Type":"WiFi","WiFi":{"SSID":"GoogleGuest","AutoConnect":true}}, function(x) { console.log(x); }) Review URL: https://codereview.chromium.org/1779633002 Cr-Commit-Position: refs/heads/master@{#381347}
* [Extensions] Gather more webRequest render frame look up metricsrdevlin.cronin2016-03-151-2/+6
| | | | | | | | BUG=455776 Review URL: https://codereview.chromium.org/1802683002 Cr-Commit-Position: refs/heads/master@{#381133}
* Extensions: Minor cleanup, formatting/lint errors.cmumford2016-03-142-10/+9
| | | | | | | | | | | | 1. Added missing STL header includes. 2. Whitespace fixup. 3. Proper ordering of forward declarations and header includes. 4. Using FRIEND_TEST_ALL_PREFIXES to eliminate test-only method. 5. Switched to range-based for loops. Review URL: https://codereview.chromium.org/1786163002 Cr-Commit-Position: refs/heads/master@{#381098}
* Migrate net/udp/* to net::IPAddress.martijn2016-03-141-6/+7
| | | | | | | | BUG=496258 Review URL: https://codereview.chromium.org/1778793003 Cr-Commit-Position: refs/heads/master@{#381019}
* Minor cleanup in TCPSocket code.lazyboy2016-03-121-7/+2
| | | | | | | | | | | | 1. Simplify and remove do{}while(false); whose purpose is not clear to me. 2. Don't assign |connect_callack_| twice. BUG=None Test=None, compiles Review URL: https://codereview.chromium.org/1793893002 Cr-Commit-Position: refs/heads/master@{#380884}
* Remove UnescapeRule::URL_SPECIAL_CHARS from chrome/ and extensions/mmenke2016-03-071-1/+2
| | | | | | | | | | | | | | | | We're removing this, in favor of PATH_SEPARATORS and URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the risk of security issues when unescaping, going forward. In most cases, this CL just replaces the old flag with both of the new ones, though in bookmark_html_reader.cc, it now uses just URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS. BUG=589257 Review URL: https://codereview.chromium.org/1767453002 Cr-Commit-Position: refs/heads/master@{#379648}
* [extensions] Fix several broken assumptions in TCP sockets APIrockot2016-03-061-3/+15
| | | | | | | | | | | | | | | | | | | This CL addresses three independent issues: 1. Undefined behavior when double-connecting a socket (hitting an unexpected DCHECK) 2. Undefined behavior when reading from a disconnected socket. (hitting an unexpected DCHECK) 3. Crash when reading from a socket with connection in progress. BUG=582650 TEST=extensive fuzzing with extension attached to linked bug, no more crashes Review URL: https://codereview.chromium.org/1767993002 Cr-Commit-Position: refs/heads/master@{#379498}
* Change scoped_ptr to be a type alias for std::unique_ptr on OS_LINUX.dcheng2016-03-032-5/+27
| | | | | | | | | | BUG=554298,579269,579270 R=danakj@chromium.org,ddorwin@chromium.org,lcwu@chromium.org,rdvelin.cronin@chromium.org,satorux@chromium.org TBR=thakis@chromium.org,yoshiki@chromium.org Review URL: https://codereview.chromium.org/1750143004 Cr-Commit-Position: refs/heads/master@{#379108}
* Migrate net::NetworkInterface to net::IPAddress.martijn2016-03-032-2/+2
| | | | | | | | | | Also adds a new constructor that takes an IPAddress and deprecates the constructor that takes an IPAddressNumber. BUG=496258 Review URL: https://codereview.chromium.org/1735983003 Cr-Commit-Position: refs/heads/master@{#379064}
* Persist the user's active audio device choice across chromeos session and ↵jennyz2016-03-021-1/+2
| | | | | | | | | | | | | | | | reboots. This cl added a new attribute to device's active state settings to describe if the device is made active by user's selection or by automatic priority selection. The device made active by user has a higher priority than the device made active by priority. With the stable device id, the active device selection rule is different than before, which only select the active device by its priority. Please see the details in the following document. https://docs.google.com/a/google.com/document/d/1zmSeM956Njh_9ZdLqyld-NTOpJyXVIfzv8DvQ1Xcksw/edit?usp=sharing BUG=308143 TBR=stevenjb,rkc,derat Review URL: https://codereview.chromium.org/1746843002 Cr-Commit-Position: refs/heads/master@{#378812}
* Plumb the correct owner document through DocumentInit::m_owner.dcheng2016-03-011-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current code tries to determine the security origin to inherit (if any) too late in document initialization. This results in strange and hard to understand behavior. For example, opener is not set until /after/ the document's security context is already initialized. To make this work, initSecurityContext() has a heuristic: if it should have inherited a security origin (e.g. the URL is about:blank) but there's nothing to inherit from, it initializes the security origin as unique, but then marks initialization as failed. When the opener is /actually/ set, it then calls initSecurityContext() again. Since the security context hasn't been marked as initialized yet, the reinitialization is allowed to proceed, and now the frame inherits its opener's security origin. Rather than going through this elaborate dance, this CL gets rid of it and proactively plumbs through the correct owner document to use. With these changes: - A security context can never be reinitialized. This requires passing the opener around when creating new windows, so that DocumentLoader can initialize the owner document correctly. - javascript: URLs have different inheritance rules: the loading machinery can now just directly pass in the correct owner document. - The exception for reusing a Window object when navigating from the initial empty Document has been removed: now it strictly follows the spec and reuses it iff it is same-origin to the new Document. BUG=583445 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1685003002 Cr-Commit-Position: refs/heads/master@{#378508}
* tracing: Make ConvertableToTraceFormat move-onlyprimiano2016-02-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary. This CL: - Makes TraceEvent ownership a move-only scoped_ptr. - Makes ConvertableToTraceFormat (CTTF) itself move-only scoped_ptr. - Updates all the codebase that uses CTTF in TRACE_EVENT macros to use move-only semantics. Background: Historically ConvertableToTraceFormat (CTTF) was RefCounted. The main reason seems to be supporting monitoring mode (now deprecated) where tracing needed to copy TraceEvents without flushing the TraceLog. Not what monitoring mode is gone, there is no reason why TraceEvent(s) should not be move-only. Unfortunately CTTF being RefCounted exposed that implementation detail to its public interface. Fortunately, most of the codebase doesn't care about the fact that CTTF is RefCounted. The only exceptions are: 1. Memory-infra heap profiler {StackFrame,TypeInfo}Deduplicator 2. cc::Layer DebugInfo 1) Is addressed creating a proxy class which delegates the CTTF methods to the duplicators inside MDSessionState. Essentially it makes the CTTF metadata events shared co-owners of the MDSessionState. 2) After an offline chat with danakj@, it seems OK to make DebugInfo(s) moved scoped_ptr (as opposite as copied), moving the ownership to the active layer and keeping a raw ptr into the pending layer. BUG=559117 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=thakis,jochen,tbarzic,mnaganov,skyostil Review URL: https://codereview.chromium.org/1717283003 Cr-Commit-Position: refs/heads/master@{#378263}
* Make extensions::DictionaryBuilder and extensions::ListValue unmovable.dcheng2016-02-272-12/+15
| | | | | | | | | | | | | | | | | | | There's no reason for these classes to be movable. std::move() is just being used as a synonym for Build(). In addition: - Build() is fewer characters than std::move(). - clang-format works better when builder syntax is consistently used, which makes it easier for readers to visually match up deeply nested builders. - It's surprising to see std::move() used with what looks like a temporary. BUG=none Review URL: https://codereview.chromium.org/1739183003 Cr-Commit-Position: refs/heads/master@{#378107}
* extensions: Add out-of-line copy ctors for complex classes.vmpstr2016-02-2724-0/+46
| | | | | | | | | | | | | This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=reillyg@chromium.org, dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1724293002 Cr-Commit-Position: refs/heads/master@{#378054}
* [chrome.displaySource] further implementation of call completion callbacksmikhail.pozdnyakov2016-02-261-5/+6
| | | | | | | | | | | | | | | | | | | The API implementation determines when and with which arguments the 'startSession'/'terminateSession' completion callbacks are invoked. The 'exceeded_session_limit_error' session error type is eliminated and substituted with 'startSession' completion callback call (which is more natural since this problem is detected before a new session is started). JS bindings code is simplified. BUG=242107 Review URL: https://codereview.chromium.org/1730583002 Cr-Commit-Position: refs/heads/master@{#377864}
* Add directories handling support for apps/extensions.cmihail2016-02-252-4/+7
| | | | | | | | | | | | | | | The change introduces a "include_directories" entry in the manifest file for file_handlers. In case the value is true, the file handler becomes a generic handler and adds the given extension to the right click menu. BUG=415897 R=mtomasz@chromium.org Review URL: https://codereview.chromium.org/1407473003 Cr-Commit-Position: refs/heads/master@{#377467}
* net: move IsLocalhost() function into url_util.htfarina2016-02-234-4/+1
| | | | | | | | | | | | | | This patch moves the last function in net_util.h into url_util.h. We are moving it there because it also operates on a URL part (host). BUG=488531 TEST=net_unittests --gtest_filter=UrlUtilTest.IsLocalhost R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1726693002 Cr-Commit-Position: refs/heads/master@{#377115}
* Assign a initial value to local variables to avoid maybe-uninitialized warningtzik2016-02-201-1/+2
| | | | | | | | | | | gcc and cl.exe start warning on a switch-case pattern for possibly uninitialized local variable with a base::Callback::Run signature modification. This CL assigns initial values to avoid it. Review URL: https://codereview.chromium.org/1704873002 Cr-Commit-Position: refs/heads/master@{#376641}
* [Extensions] Wire in the ActiveScriptController with WebRequestrdevlin.cronin2016-02-175-23/+41
| | | | | | | | | | | Finish the process of wiring up webRequest with the rest of the blocked actions by notifying the ActiveScriptController of a webRequest that was withheld. BUG=460306 Review URL: https://codereview.chromium.org/1694973002 Cr-Commit-Position: refs/heads/master@{#375968}
* Remove "experimental-html" from chrome.app.windowrob2016-02-152-19/+1
| | | | | | | | | The "experimental-html" frame option is behind a flag, undocumented and seems not used by real app developers. Review URL: https://codereview.chromium.org/1690893003 Cr-Commit-Position: refs/heads/master@{#375443}
* [chrome.displaySource] Simplify session error typesmikhail.pozdnyakov2016-02-151-4/+3
| | | | | | | | | | | This patch reduces amount of possible session error types and makes them more generic (less WiFi Display oriented). BUG=242107 Review URL: https://codereview.chromium.org/1689913003 Cr-Commit-Position: refs/heads/master@{#375437}
* Construct USB descriptors over explicit values.reillyg2016-02-121-7/+4
| | | | | | | | | | | | Instead of specifying a bunch of arbitrary defaults and then updating them in the code building the structure. This makes them friendly to use with C++11's emplace_back() method. BUG=None Review URL: https://codereview.chromium.org/1468423003 Cr-Commit-Position: refs/heads/master@{#375081}
* [Extensions] Hook the webRequest API into tab permissions with click-to-scriptrdevlin.cronin2016-02-116-13/+34
| | | | | | | | | | | | | | | | | With click-to-script turned on, webRequest needs to respect tab-specific permissions so that when the user grants access to a tab, the extension can operate on it. In order to do this, we also need access to the tab id on the IO thread. Add the tab id to the ExtensionApiFrameIdMap, and check for it in the webRequest api. For now, don't do anything if the frame isn't cached - that'll come later. This also doesn't hook webRequest into requesting permissions - that's next. BUG=460306 Review URL: https://codereview.chromium.org/1687913002 Cr-Commit-Position: refs/heads/master@{#375036}
* [chrome.displaySource] Session notification improvementsmikhail.pozdnyakov2016-02-112-45/+65
| | | | | | | | | | | | | | | | | | This patch provides several fixes and improvements (simplifications) to the session life cycle notification mechanism: 1) The 'startSession'/'terminateSession' call completion callbacks are invoked when the session is actually started/terminated and in accordance with 'onSessionStarted'/'onSessionTerminated' events propagating (and as per documentation). 2) The notification from the required sink is filtered out in browser process avoiding unneeded IPC calls 3) Methods in mojo interface are renamed in order to improve readability BUG=242107 Review URL: https://codereview.chromium.org/1674583002 Cr-Commit-Position: refs/heads/master@{#374929}
* Add frameId to chrome.tabs.executeScript/insertCSSrob2016-02-071-12/+9
| | | | | | | | | | | | | | | | | | | | | | | | - Re-implemented https://codereview.chromium.org/952473002/, with all checks at the browser side instead of just the renderer. - Use the last committed URL for checking permissions instead of the visible URL. As a result, executeScript/insertCSS will now succeed in frames where the currently committed page is scriptable by extensions, but the target of the pending navigation is is not. - ExecuteScript: Do not send IPC to non-live frames (they're not going to reply anyway). - Include URL in the error if the extension has the tabs permission (follow-up to TODO from https://codereview.chromium.org/1414223005). BUG=63979,551626 TEST=./browser_tests --gtest_filter=ExecuteScriptApiTest.* CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1628423002 Cr-Commit-Position: refs/heads/master@{#374057}
* Make UsbDeviceHandle::ReleaseInterface asynchronous.reillyg2016-02-042-5/+13
| | | | | | | | | | | | | | | | | This patch adds a callback to UsbDeviceHandle::ReleaseInterface that is called when the interface has been released. Previously this result was returned synchronously while the actual release operation happened in the background. In the process I've fixed an issue where libusb_release_interface could have been called from the UI thread if there were no pending transfers to delay it. BUG=None Review URL: https://codereview.chromium.org/1664023002 Cr-Commit-Position: refs/heads/master@{#373641}
* Make extensions use a correct same-origin check.palmer2016-02-031-3/+4
| | | | | | | | | | GURL::GetOrigin does not do the right thing for all types of URLs. BUG=573317 Review URL: https://codereview.chromium.org/1658913002 Cr-Commit-Position: refs/heads/master@{#373381}
* Reland of Update device/usb and its Mojo interface for variable size ISO ↵reillyg2016-02-023-32/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | packets. (patchset #1 id:1 of https://codereview.chromium.org/1658953003/ ) Reason for revert: Fixed the uninitialized test buffer. Original issue's description: > Revert of Update device/usb and its Mojo interface for variable size ISO packets. (patchset #3 id:120001 of https://codereview.chromium.org/1618393004/ ) > > Reason for revert: > Uninit error from UsbApiTest.TransferFailure > > BUG=583343 > > Original issue's description: > > Update device/usb and its Mojo interface for variable size ISO packets. > > > > To support the WebUSB API our underlying USB library needs to support > > isochronous transfers with full control over the packet size. We also > > need to know the completion status of each packet which was previously > > not available. > > > > This patch updates the interface to match that provided by libusb and > > the underlying platform specific APIs. > > > > BUG=492204 > > > > Committed: https://crrev.com/051c98e9d3e843295d659b5676fcfa9dc1be5da6 > > Cr-Commit-Position: refs/heads/master@{#372844} > > TBR=scheib@chromium.org,dgozman@chromium.org,reillyg@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=492204 > > Committed: https://crrev.com/c40c36ef3d3a722e0df920a4bbae25695f0b18e8 > Cr-Commit-Position: refs/heads/master@{#372971} TBR=scheib@chromium.org,dgozman@chromium.org,zhaoqin@chromium.org BUG=583343 Review URL: https://codereview.chromium.org/1665453002 Cr-Commit-Position: refs/heads/master@{#373065}
* Revert of Update device/usb and its Mojo interface for variable size ISO ↵zhaoqin2016-02-023-122/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | packets. (patchset #3 id:120001 of https://codereview.chromium.org/1618393004/ ) Reason for revert: Uninit error from UsbApiTest.TransferFailure BUG=583343 Original issue's description: > Update device/usb and its Mojo interface for variable size ISO packets. > > To support the WebUSB API our underlying USB library needs to support > isochronous transfers with full control over the packet size. We also > need to know the completion status of each packet which was previously > not available. > > This patch updates the interface to match that provided by libusb and > the underlying platform specific APIs. > > BUG=492204 > > Committed: https://crrev.com/051c98e9d3e843295d659b5676fcfa9dc1be5da6 > Cr-Commit-Position: refs/heads/master@{#372844} TBR=scheib@chromium.org,dgozman@chromium.org,reillyg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=492204 Review URL: https://codereview.chromium.org/1658953003 Cr-Commit-Position: refs/heads/master@{#372971}
* Update device/usb and its Mojo interface for variable size ISO packets.reillyg2016-02-023-32/+122
| | | | | | | | | | | | | | | | To support the WebUSB API our underlying USB library needs to support isochronous transfers with full control over the packet size. We also need to know the completion status of each packet which was previously not available. This patch updates the interface to match that provided by libusb and the underlying platform specific APIs. BUG=492204 Review URL: https://codereview.chromium.org/1618393004 Cr-Commit-Position: refs/heads/master@{#372844}
* Implement webview.captureVisibleRegion()wjmaclean2016-02-015-70/+133
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL implements webview.captureVisibleRegion(), an extension/apps API to allow WebView users to capture screenshots of the contents displayed in a WebView. The surfaces contents capture has been plumbed via RenderWidgetHostViewChildFrame so this implementation should not require changes when WebView switches to using OOPIF. As part of the implementation, there are two notable refactors: 1) CaptureWebContentsFunction has been refactored into WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction dependence so that this code can be used by both tabs.captureVisibleTab and webview.captureVisibleRegion, and 2) common code from DelegatedFrameHost has ben moved to content/browser/compositor/surface_utils.* in order to avoid duplication as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now use the code. Finally, this CL adds a surface-drawn callback to RenderWidgetHostViewChildFrame, to allow deferring a screen capture request until a frame has actually been drawn. This callback can be used to simplify some existing tests. BUG=326755 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1635513003 Cr-Commit-Position: refs/heads/master@{#372799}
* Remove the code added to make extensions compile on Aura Android.mfomitchev2016-01-281-3/+0
| | | | | | | | BUG=NONE Review URL: https://codereview.chromium.org/1551423003 Cr-Commit-Position: refs/heads/master@{#372106}
* Change IPEndpoint::address() to return a net::IPAddressmartijn2016-01-271-1/+1
| | | | | | | | | | | | | | | This CL is part of the net::IPAddressNumber migration[1]. IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to return a net::IPAddress. BUG=496258 TBR=scheib [1] https://code.google.com/p/chromium/issues/detail?id=496258#c10 Review URL: https://codereview.chromium.org/1565303002 Cr-Commit-Position: refs/heads/master@{#371750}
* Remove now-unnecessary wrappers around gfx::Screen::GetScreen()scottmg2016-01-273-10/+2
| | | | | | | | | | | | | | - ash::Shell::GetScreen() - DisplayInfoProvider::GetActiveScreen() Followup to https://codereview.chromium.org/1608733002/. R=oshima@chromium.org, sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1608053002 Cr-Commit-Position: refs/heads/master@{#371733}
* Remove ui/gfx/screen_type_delegate.hscottmg2016-01-273-6/+4
| | | | | | | | | | | | | | This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is now only one Screen instance. It's still a runtime-installed thing for test purposes. TBR=various owners for trivial changes R=oshima@chromium.org, sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1608733002 Cr-Commit-Position: refs/heads/master@{#371676}
* webRequest: Check weak ptr before dispatching eventrob2016-01-261-0/+3
| | | | | | | | BUG=581148 Review URL: https://codereview.chromium.org/1632963002 Cr-Commit-Position: refs/heads/master@{#371418}
* Remove use of void** from HttpResponseHeaders::EnumerateHeaderolli.raula2016-01-252-2/+2
| | | | | | | | | | | Remove use of of obaque void** and use instead size_t* parameter. Logic inside is untouched. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1607773005 Cr-Commit-Position: refs/heads/master@{#371204}
* Expose stable_device_id in audio extension apis.jennyz2016-01-212-8/+14
| | | | | | | | BUG=466768 Review URL: https://codereview.chromium.org/1584613003 Cr-Commit-Position: refs/heads/master@{#370730}
* Remove use of void** from HttpResponseHeaders::EnumerateHeaderLinesolli.raula2016-01-214-5/+5
| | | | | | | | | | | Remove use of of obaque void** and use instead size_t* parameter. Logic inside is untouched. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1594973004 Cr-Commit-Position: refs/heads/master@{#370672}
* [chrome.displaySource] DisplaySourceConnectionDelegate::Connection interfacemikhail.pozdnyakov2016-01-215-23/+95
| | | | | | | | | | | | | Extend DisplaySourceConnectionDelegate::Connection interface to support control message exchange with the connected sink. Also connection error notification method is added. BUG=242107 Review URL: https://codereview.chromium.org/1603013002 Cr-Commit-Position: refs/heads/master@{#370661}
* Revert of Implement webview.captureVisibleRegion() (patchset #9 id:160001 of ↵tsergeant2016-01-215-119/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1582053002/ ) Reason for revert: The test WebViewAPITest.TestCaptureVisibleRegion is failing on several windows bots: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/45040 https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/42690 https://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/64394 Original issue's description: > Implement webview.captureVisibleRegion() > > This CL implements webview.captureVisibleRegion(), an extension/apps > API to allow WebView users to capture screenshots of the contents > displayed in a WebView. The surfaces contents capture has been plumbed > via RenderWidgetHostViewChildFrame so this implementation should not > require changes when WebView switches to using OOPIF. > > As part of the implementation, there are two notable refactors: > > 1) CaptureWebContentsFunction has been refactored into > WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction > dependence so that this code can be used by both tabs.captureVisibleTab > and webview.captureVisibleRegion, and > > 2) common code from DelegatedFrameHost has ben moved to > content/browser/compositor/surface_utils.* in order to avoid duplication > as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now > use the code. > > BUG=326755 > > Committed: https://crrev.com/5b8cdcc82fc9da7bab15fd3dbf65df843dc73589 > Cr-Commit-Position: refs/heads/master@{#370565} TBR=rockot@chromium.org,creis@chromium.org,kenrb@chromium.org,nick@chromium.org,fsamuel@chromium.org,wjmaclean@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=326755 Review URL: https://codereview.chromium.org/1614703003 Cr-Commit-Position: refs/heads/master@{#370641}
* Change mojo enums to be scoped enums in the generated C++ bindings.sammc2016-01-211-44/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | Some mojo enums were previously not proper enums: they were constants for bitfields. These have been replaced by const int32s in the mojoms: - mus.mojom.EventFlags - mus.mojom.MouseEventFlags - mus.mojom.ResizeBehavior - mus.mojom.WindowTree.AccessPolicy Some mojo enum values now conflict with macros (mostly on Windows) and needed to change: - mus.mojom.Cursor.NULL became CURSOR_NULL (again) - mus.mojom.KeyboardCode.DELETE became DELETE_KEY - mus.mojom.WindowManagerErrorCode.ERROR_ACCESS_DENIED became ACCESS_DENIED - device.usb.TransferDirection.IN became INBOUND - device.usb.TransferDirection.OUT became OUTBOUND - device.usb.TransferStatus.ERROR became TRANSFER_ERROR - device.NFCRecordType.OPAQUE became OPAQUE_RECORD - media.interfaces.Decryptor.Status.ERROR became DECRYPTION_ERROR - skia.AlphaType.OPAQUE became ALPHA_TYPE_OPAQUE Review URL: https://codereview.chromium.org/1527183003 Cr-Commit-Position: refs/heads/master@{#370632}
* Expose versionName to management apilimasdf2016-01-211-0/+2
| | | | | | | | | | | exposing versionName if 'version_name' is set in manifest.json BUG=445827 TEST=browser_tests --gtest_filter=ExtensionManagementApiTest.Basics Review URL: https://codereview.chromium.org/1590793005 Cr-Commit-Position: refs/heads/master@{#370631}
* Implement webview.captureVisibleRegion()wjmaclean2016-01-215-70/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | This CL implements webview.captureVisibleRegion(), an extension/apps API to allow WebView users to capture screenshots of the contents displayed in a WebView. The surfaces contents capture has been plumbed via RenderWidgetHostViewChildFrame so this implementation should not require changes when WebView switches to using OOPIF. As part of the implementation, there are two notable refactors: 1) CaptureWebContentsFunction has been refactored into WebContentsCaptureClient to remove the extensions::AsyncExtensionFunction dependence so that this code can be used by both tabs.captureVisibleTab and webview.captureVisibleRegion, and 2) common code from DelegatedFrameHost has ben moved to content/browser/compositor/surface_utils.* in order to avoid duplication as both DelegatedFrameHost and RenderWidgetHostViewChildFrame now use the code. BUG=326755 Review URL: https://codereview.chromium.org/1582053002 Cr-Commit-Position: refs/heads/master@{#370565}
* net: move more functions out of net_util.htfarina2016-01-201-1/+1
| | | | | | | | | | | | | | | | | | This moves everything except IsHostnameNonUnique(), GetHostName(), ResolveLocalHostname() and IsLocalhost() out of net_util.h, moving them into url_util.h. We will discuss what to do with the remaining 4 functions in a separate CL. BUG=488531 TEST=net_unittests R=eroman@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/1585773008 Cr-Commit-Position: refs/heads/master@{#370385}
generated by cgit v1.1 at 2025-01-08 03:54:18 +0000