| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
We no longer need to support shaped desktop, so the corresponding
code can be removed.
Review URL: https://codereview.chromium.org/1827043004
Cr-Commit-Position: refs/heads/master@{#383340}
|
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
Cr-Commit-Position: refs/heads/master@{#382939}
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#383105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1817573003/ )
Reason for revert:
Breaks downstream Android ToT builds, and hence prevents Chromium changes rolling into downstream Android builds.
BUG= 597559
Original issue's description:
> Move ServiceUrls to remoting/host
>
> ServiceUrls was used only in one place in android client and it's
> not really useful there. Moved it to the host directory.
>
> TBR=rogerta@chromium.org
>
> Committed: https://crrev.com/2a2656a67bd2ce190df4d918f609bdb4449a64fe
> Cr-Commit-Position: refs/heads/master@{#382939}
TBR=lambroslambrou@chromium.org,rogerta@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1830993002
Cr-Commit-Position: refs/heads/master@{#383060}
|
|
|
|
|
|
|
|
|
|
|
| |
ServiceUrls was used only in one place in android client and it's
not really useful there. Moved it to the host directory.
TBR=rogerta@chromium.org
Review URL: https://codereview.chromium.org/1817573003
Cr-Commit-Position: refs/heads/master@{#382939}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the IPC client class used to communicate with the
Chromoting host's network process to allow for forwarding security key
requests.
BUG=584463
Review URL: https://codereview.chromium.org/1767763002
Cr-Commit-Position: refs/heads/master@{#381117}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds the GnubbyAuthHandlerWin class which services IPC clients that
want to forward security key messages to the remote client. This class creates
a new RemoteSecurityKeyIpcServer instance for each client so that multiple
security key requests can be serviced simultaneously.
BUG=584463
Review URL: https://codereview.chromium.org/1765743002
Cr-Commit-Position: refs/heads/master@{#381077}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces the IPC Server class used to communicate with the
remote_security_key process for SK forwarding. It also includes unit
tests and some facilities that will be used in the subsequent change
which will implement the GnubbyAuthHandlerWin class.
BUG=584463
Review URL: https://codereview.chromium.org/1757873003
Cr-Commit-Position: refs/heads/master@{#381054}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a result of feedback from the GnubbyAuthHandler
refactoring. Since we will have platform specific implementations of
the GnubbyAuthHandler, we should try to have a single header defining
the interface and platform specific cc files for the impl.
The Linux impl had a header which was used by its unit tests, however I
think the test methods could be generic enough that the ForTest()
methods make sense to have on the interface as the unittests for each
impl will use them. This simplifies the code in the unittests and
allows us to hide the platform specific impls in the cc file and remove
the platform specific headers.
BUG=587298
Review URL: https://codereview.chromium.org/1720243002
Cr-Commit-Position: refs/heads/master@{#377167}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change breaks the logic in the GnubbyAuthHandlerLinux class into
platform-specific and platform-agnostic chunks. The platform-specific
logic has remained in the GnubbyAuthHandlerLinux class whereas the
platform-agnostic code was moved into a new HostExtension class
(GnubbyHostExtensionSession). This allows us to add a Gnubby host
extension if it is supported by policy and remove the logic and plumbing
for gnubby message handling from ClientSession and the many
DesktopEnvironment classes.
BUG=584463
Review URL: https://codereview.chromium.org/1689003002
Cr-Commit-Position: refs/heads/master@{#375797}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves the existing Gnubby files into a new security_key
directory. Since I will be refactoring this and expanding the number of
files, I thought it would be better to keep them orgainzed in a
sub-directory vs. adding all of th files to the host root directory.
Also needed to update the Presubmit file for the AllowScopedIO
exception.
BUG=584463
Review URL: https://codereview.chromium.org/1668393002
Cr-Commit-Position: refs/heads/master@{#374177}
|
|
|
|
|
|
|
|
|
|
|
| |
Added MouseCursorMonitorProxy which is now responsible for switching to
the capture thread to capture mouse shape.
BUG=458437
Review URL: https://codereview.chromium.org/1669143002
Cr-Commit-Position: refs/heads/master@{#373912}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new TransportContext is now used to store all parameters required
to initialize Transport objects and is applicable both to IceTransport
and WebrtcTransport. It also allowed to reduce amount of boilerplate
code when passing around these parameters.
BUG=547158
Review URL: https://codereview.chromium.org/1521883006
Cr-Commit-Position: refs/heads/master@{#365649}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added new VideoStream interface. VideoFramePump implements it. Later
there will be a separate implementation for WebRTC-based protocol.
ConnectionToClient is responsible for VideoStream creation.
BUG=547158
Review URL: https://codereview.chromium.org/1472873005
Cr-Commit-Position: refs/heads/master@{#362096}
|
|
|
|
|
|
|
|
|
|
|
|
| |
protocol/webrtc_video_capture_adapter
The adapter will be used in the protocol layer for WebRTC-based connections.
BUG=547158
Review URL: https://codereview.chromium.org/1472703006
Cr-Commit-Position: refs/heads/master@{#361465}
|
|
|
|
|
|
|
|
|
|
|
| |
VideoFramePump will not be used for WebRTC-based connection. In a separate
change I plan to move creation of the VideoFramePump to IceConnectionToHost
so the host layer will not need to know when VideoFramePump needs to be
used.
Review URL: https://codereview.chromium.org/1462063004
Cr-Commit-Position: refs/heads/master@{#361205}
|
|
|
|
|
|
|
|
| |
BUG=547158
Review URL: https://codereview.chromium.org/1419783013
Cr-Commit-Position: refs/heads/master@{#358751}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no reason curtain_mode and signal_handler need to be
in remoting_me2me_host_static instead of remoting_host. Also currently
try bots don't compile Me2Me host and so they don't detect some
potential breakages, e.g. as in
https://codereview.chromium.org/1430503002/ .
Also added USE_REMOTING_MACOSX_INTERNAL which was missing in the GN build
Review URL: https://codereview.chromium.org/1417853005
Cr-Commit-Position: refs/heads/master@{#357600}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Chrome Remote Desktop daemon application will collect the host OS and
versionHost OS name and version will then be collected by the Chrome Remote backend for analysis on error reports to help improve the stability of the product.
Version was missing on linux systems.
R=kelvinp@chromium.org, sergeyu@chromium.org
BUG=534902
Review URL: https://codereview.chromium.org/1365983002
Cr-Commit-Position: refs/heads/master@{#351366}
|
|
|
|
|
|
|
|
| |
base/resources.h is used only in host, so it doesn't need to be in base.
Review URL: https://codereview.chromium.org/1318773003
Cr-Commit-Position: refs/heads/master@{#345719}
|
|
|
|
|
|
|
|
|
|
| |
This replaces a single onDone(result) callback with a pair (onDone(), onError(message, location)). The error message and location are communicated via native messaging as additional parameters, which should ensure backwards-compatibility in both directions.
BUG=517176
Review URL: https://codereview.chromium.org/1272833002
Cr-Commit-Position: refs/heads/master@{#344622}
|
|
|
|
|
|
|
|
|
| |
Move process switch name constants from host_main.cc and ipc_constants.* to
dedicated header.
Review URL: https://codereview.chromium.org/267053009
Cr-Commit-Position: refs/heads/master@{#341622}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. GN builds were not including some tests included in GYP.
2. Replaced test_common target in gyp with test_support.
3. Removed extra *_common targets for test_driver and moved everything
to test_support.
4. test_driver can be compiled using GN now.
5. Various other small cleanups.
Review URL: https://codereview.chromium.org/1228283004
Cr-Commit-Position: refs/heads/master@{#339119}
|
|
|
|
|
|
|
|
| |
BUG=471928
Review URL: https://codereview.chromium.org/1124043002
Cr-Commit-Position: refs/heads/master@{#332330}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not possible to use Xrandr to configure the display in ozone
builds. This code does not work anyway, so replace it with a stub so
that we can actually compile without putting X into the build
environment.
BUG=484324
TEST=build for chromebook pixel with
https://chromium-review.googlesource.com/#/c/269135/
Review URL: https://codereview.chromium.org/1120753009
Cr-Commit-Position: refs/heads/master@{#328813}
|
|
|
|
|
|
|
|
|
|
| |
HostSignalingManager was added so the signaling connection outlive
HostProcess object. That's no longer necessary and so this class can be
removed as it wasn't doing anything useful anyway.
Review URL: https://codereview.chromium.org/1123973002
Cr-Commit-Position: refs/heads/master@{#328632}
|
|
|
|
|
|
|
|
| |
BUG=471928
Review URL: https://codereview.chromium.org/1099553003
Cr-Commit-Position: refs/heads/master@{#327144}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have the Chromoting host write logs to syslog. This works around the
issue where, in some Yosemite configurations, launchd fails to start the
agent if the user running the agent does not have write access to the
log or the log's directory.
Logging to syslog has additional advantages such as:
- Log rotation and overflow are now managed by the system.
- Messages are read-restricted to the user running the agent.
After this change, logs will no longer be stored in
/var/log/org.chromium.chromoting.log. To obtain logs, use the following
command:
sudo syslog -k Facility org.chromium.chromoting
If 'sudo' is omitted, messages logged in the login screen (while the
agent is running as root) will not be available.
N.B. The changes to ChromotingHostService.pkgproj were made using the 'Packages'
program. To test the changes, I built and installed a .dmg from scratch.
BUG=468121
Review URL: https://codereview.chromium.org/1073883002
Cr-Commit-Position: refs/heads/master@{#324550}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update SessionInputInjectorWin and InputInjectorWin to
handle touch events.
- Add TouchInjectorWin which converts TouchEvents to
structs for Windows touch injection API.
BUG=314515
Review URL: https://codereview.chromium.org/991643002
Cr-Commit-Position: refs/heads/master@{#322116}
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/961323004
TBR=dpranke
Review URL: https://codereview.chromium.org/969173002
Cr-Commit-Position: refs/heads/master@{#319080}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change a malformed value of RemoteAccessHostUdpPortRange policy
(i.e. "123456-blah") was ignored and a default value was used. Similarily for
the 3 third-party-auth-config policies (RemoteAccessHostTokenUrl,
...TokenValidationUrl and ...TokenValidationCertificateIssuer) we were falling
back to a secure default, but not reporting a policy error. After this change
such malformed values will trigger an OnPolicyError callback.
Notes:
- Guaranteeing that PolicyWatcher always returns valid policy values, removes
the need for a "rejecting" Me2MeHostAuthenticatorFactory.
- Moving PortRange and ThirdPartyAuthConfig to separate compilation units
helps readability elsewhere + encourages better unit tests coverage.
- Initially I tried to wrap all policies in a new ChromotingPolicies class,
but eventually went back to prevalidating and passing base::DictionaryValue.
- Arguments for using ChromotingPolicies:
- Helps avoid overtesting in policy_watcher_unittests.cc (i.e. helps focus
the tests on a single policy value).
- Arguments for using base::DictionaryValue:
- Minimizes changes.
- Keeps things simple (as opposed to having to introduce a custom
equivalent of optional<T> [nothing similar present in Chromium AFAICT]).
- Neutral:
- Strong-typing of ChromotingPolicies didn't help readability as much as I
expected and hoped for.
BUG=427513
TEST=remoting_unittests
Review URL: https://codereview.chromium.org/966433002
Cr-Commit-Position: refs/heads/master@{#318910}
|
|
|
|
|
|
|
|
| |
BUG=463132
Review URL: https://codereview.chromium.org/969133002
Cr-Commit-Position: refs/heads/master@{#318819}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/961323004/)
Reason for revert:
broke windows GN builds as seen in
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> Reland of https://codereview.chromium.org/965633002/
>
> TBR=dpranke
>
> Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f
> Cr-Commit-Position: refs/heads/master@{#318756}
TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/968243004
Cr-Commit-Position: refs/heads/master@{#318772}
|
|
|
|
|
|
|
|
|
|
| |
Reland of https://codereview.chromium.org/965633002/
TBR=dpranke
Review URL: https://codereview.chromium.org/961323004
Cr-Commit-Position: refs/heads/master@{#318756}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/965633002/)
Reason for revert:
http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=4498
ERROR at //remoting/host/BUILD.gn:56:7: Item not found
"linux/x_server_clipboard.cc",
^----------------------------
You were trying to remove "linux/x_server_clipboard.cc"
Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> BUG=
>
> Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37
> Cr-Commit-Position: refs/heads/master@{#318539}
TBR=kelvinp@chromium.org,dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/970443002
Cr-Commit-Position: refs/heads/master@{#318545}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/965633002
Cr-Commit-Position: refs/heads/master@{#318539}
|
|
|
|
|
|
|
|
|
|
|
|
| |
For tools/sort_sources.py to be useful, existing GYP and GN files
should be sorted.
BUG=456014
TEST=everything should build as before
Review URL: https://codereview.chromium.org/934703002
Cr-Commit-Position: refs/heads/master@{#316733}
|
|
|
|
|
|
|
|
|
|
|
| |
This is similar to the VideoScheduler refactoring. AudioPump now is not
ref-counted, but otherwise works the same as AudioScheduler.
Also simplified AudioCapturer interface.
Review URL: https://codereview.chromium.org/866863004
Cr-Commit-Position: refs/heads/master@{#316277}
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Threading logic for the capture thread has been moved to
ScreenCapturerProxy.
2. Mouse shape handling has been moved to MouseShapePump.
BUG=455818
Review URL: https://codereview.chromium.org/883673004
Cr-Commit-Position: refs/heads/master@{#316247}
|
|
|
|
|
|
|
|
| |
BUG=455818
Review URL: https://codereview.chromium.org/893353002
Cr-Commit-Position: refs/heads/master@{#314917}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we are reusing code from components/policy, so we can get rid of the
self-shaming "hack" name in the policy_hack namespace and directory.
The changelist also:
- Inlines MockPolicyCallback into policy_watcher_unittest.cc
- Removes a misguided TODO comment in policy_watcher.h that used
to say that components/policy filters out policies that do not
match the schema (this is not true for polices from Chrome domain
- see SchemaMap::FilterMap definition).
BUG=368321
Review URL: https://codereview.chromium.org/884243003
Cr-Commit-Position: refs/heads/master@{#313819}
|
|
|
|
|
|
|
|
| |
BUG=368321
Review URL: https://codereview.chromium.org/867463006
Cr-Commit-Position: refs/heads/master@{#313570}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removal of FakePolicyWatcher means that PolicyServiceWatcher is now the only
class derived from PolicyWatcher. A next check-in should merge PolicyWatcher
and PolicyServiceWatcher into a single class.
Testing via FakeAsyncPolicyLoader rather than FakePolicyWatcher means that
tests cover more of PolicyServiceWatcher code.
I chose to introduce FakeAsyncPolicyLoader, rather than going via an already
existing MockConfigurationPolicyProvier, because 1) this way I can cover more
of PolicyServiceWatcher code and 2) this simplifies the test code (by a) keeping
PolicySchema manipulation within the product code and b) not requiring mocking
of IsInitializationComplete and c) being able to directly call into unmodified
CreateFromPolicyLoader method in the product code).
BUG=368321
Review URL: https://codereview.chromium.org/858303003
Cr-Commit-Position: refs/heads/master@{#312994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist removes PolicyWatcherLinux/Win/Mac from
src/remoting/host/policy_hack (which had most of the code copied from
various classes that are now refactored into src/components/policy) and
replaces these classes with PolicyServiceWatcher that wraps a
PolicyService from src/components/policy. PolicyServiceWatcher is based
on a mostly unchanged PolicyWatcherChromeOS, which has been made
applicable to other OS-es, by enabling wrapping an *owned* PolicyService
(and by adding code that creates the owned PolicyService).
This changelist focuses on making minimal changes that:
1) preserve current behavior of PolicyWatcher
2) replace PolicyWatcherLinux/Win/Mac with PolicyServiceWatcher
The focused/minimal nature of the changelist means that some undesirable
or questionable aspects of PolicyWatcher remain untouched. For example:
A) src/remoting/host/policy_hack uses same policy dir path on Chrome
and Chromium (unlike src/chrome/browser/policy)
B) PolicyWatcher still contains quite a bit of business logic
(i.e. for filling out default values or using special fallback
values in case of incorrect value types)
C) PolicyWatcher's users consume policies via base::DictionaryValue
rather than policy::PolicyMap
D) Users of PolicyWatcher have to be aware of threading gotchas (i.e.
It2MeHost::OnPolicyUpdate has to account for the fact that on
ChromeOS, PolicyWatcher's callbacks are called on browser's UI thread
rather than on Chromoting's network_task_runner)
The changelist fails to preserve the following behavior of PolicyWatcher:
*) Policy parsing errors are not surfaced anymore to users of PolicyWatcher
Not retaining this behavior is probably okay because:
i) If the security lock down response to parsing errors is desirable, then we
should detect and surface this from component/policy, so that all Chrome
policies benefit (i.e. security-sensitive AlwaysAuthorizePlugins,
AudioCaptureAllowed or URLBlacklist)
ii) Code reuse from the current changelist allows detecting currently
undetected policy authoring problems in Chromoting scenarios (i.e.
by making it possible to validate policy value types via policy::Schema).
iii) Current policy-errors behavior is far from bullet-proof:
- Misspelled policy names are inherently undetectable
- Invalid types of policy values are ignored on Windows and Mac
(as mentioned above in (ii) and tracked by crbug.com/427513)
- Up until recently (until changelist here:
https://chromium.googlesource.com/chromium/src.git/+/142f8e1d3e4b75c901f33cb771cd848019630c1e)
malformed json files prevented chromoting host from starting but did
*not* stop an already running host (only prevented the already running
host from ever refreshing policies from other, still parseable files).
iv) Reuniting remoting/host/policy_hack with components/policy is automatically
bringing in other features (i.e. detecting policy updates on Mac).
The changelist has been tested by manually dumping and verifying policy
contents via the newly added unit test on Linux, Windows and Mac.
BUG=368321
Review URL: https://codereview.chromium.org/830193002
Cr-Commit-Position: refs/heads/master@{#311994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introducing HostSignalingManager for extending host process's
lifetime while we wait for an ack to host-offline-reason heartbeat.
- HostSignalingManager is needed primarily to control process
lifetime by holding a ref-count to network_task_runner via a field
of HostSignalingManager - network_task_runner (via its
stop/join) callback) keeps a ref-count to the main thread
(ui_task_runner). And main thread / ui_task_runner will keep the
whole process running until its refcount drops to zero.
- Introducing HostSignalingManager also helps take multiple
fields that used to be held by HostProcess and embed/hide those
fields/objects inside HostSignalingManager
- Lifetime of HostSignalingManager is temporarily extended while
we are waiting for a timeout or ack to host-offline-reason
heartbeat.
BUG=410050
Review URL: https://codereview.chromium.org/719983002
Cr-Commit-Position: refs/heads/master@{#311077}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for a native confirmation dialog shown after the
user presses "Share" on the webapp but before an access code is
generated. It also includes a ChromeOS (Aura) implementation.
Implementation for other platforms will soon follow.
More details
============
It2MeConfirmationDialog is an interface for the confirmation dialog.
Implementations can assume they will be called only on the UI thread.
It2MeConfirmationDialogFactory is used to create platform specific
implementations of the dialog.
It2MeConfirmationDialogChromeOS is the dialog's ChromeOS implementation.
It2MeConfirmationDialogProxy is a helper class that allows the caller
(in this case, It2MeHost) to use the dialog outside of the UI thread.
BUG=444216
Review URL: https://codereview.chromium.org/816903002
Cr-Commit-Position: refs/heads/master@{#310149}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The host process is meant to shut down cleanly when receiving a SIGTERM,
or if there is a configuration error.
This CL implements a timed watchdog, running on a new thread, that
triggers a forced exit of the process, in case it fails to terminate
normally within a reasonable time (for example, if some thread is inside
a blocking call).
BUG=420090
TEST=The watchdog shouldn't normally trigger, but I manually added a Sleep() to some thread to verify that it triggers if a thread is blocked for too long.
Review URL: https://codereview.chromium.org/784243003
Cr-Commit-Position: refs/heads/master@{#307819}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements InputInjectorChromeOS with the SystemInputInjector API.
It also introduce a new class, DisplayRotationFilter, on the input pipeline to handle
display rotation settings on Ozone.
BUG=426716
Review URL: https://codereview.chromium.org/756643006
Cr-Commit-Position: refs/heads/master@{#307558}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces a class that monitors the changes in cursor shape
on Chrome OS. This CL also updates X11-based ChromeOS system
to use this cursor monitor.
BUG=431457,437955
Review URL: https://codereview.chromium.org/779443002
Cr-Commit-Position: refs/heads/master@{#307200}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing host_status_sender.cc and moving this functionality into
heartbeat_sender.cc. This avoids multiple issues related to
duplicated code and functionality:
- primarily, this enables sequence-id-based signatures (which are
better than timestamp based signatures - they don't require the host
and the bot to have synchronized clocks) without having to maintain
a separate sequence id for host status messages.
- secondarily, this means we can avoid much code duplication (on the
client side, but mostly on the server side)
Note that server side currently doesn't handle host-status messages
that are being removed by this changelist.
Handling of host-offline-reason attribute being added by this
changelist needs to be added to server side. This is being tracked by
cr/78625042
BUG=410050
Review URL: https://codereview.chromium.org/719973002
Cr-Commit-Position: refs/heads/master@{#305756}
|
|
|
|
|
|
|
|
| |
BUG=416308
Review URL: https://codereview.chromium.org/697483002
Cr-Commit-Position: refs/heads/master@{#305380}
|