| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Following android's documentation, native apps can set a referrer with
the format android-app://com.foo.bar. This is supported by the Java
side, but not the native code.
TBR=alokp@chromium.org,asargent@chromium.org # Adding a parameter in chromecast/ and extensions/
TESTED=adb shell am start -n com.google.android.apps.chrome/.Main -a "android.intent.action.VIEW" -d 'http://www.whatismyreferer.com/' --eu "android.intent.extra.REFERRER" "android-app://com.foo.bar"
BUG=537863
Review URL: https://codereview.chromium.org/1416863004
Cr-Commit-Position: refs/heads/master@{#376423}
|
|
|
|
|
|
|
|
|
| |
BUG=138542
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/1543053002
Cr-Commit-Position: refs/heads/master@{#366716}
|
|
|
|
|
|
|
|
| |
BUG=557422
Review URL: https://codereview.chromium.org/1537893002
Cr-Commit-Position: refs/heads/master@{#366120}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is another piece of work towards implementing differential
extensions update and share autoupdate code with the chrome components
system. It adds code to the extensions/browser directory that makes use
of the common autoupdate code via the update_client::UpdateClient class
to send update checks to the server, download a full .crx or
differential update, and hand back an unpacked directory with the
contents of the new extension version.
This CL does not yet add any code in chrome/ that actually uses these
new capabilities; that will be in a forthcoming CL.
BUG=490418
Review URL: https://codereview.chromium.org/1362043005
Cr-Commit-Position: refs/heads/master@{#354370}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace a bunch of pointers with const&.
TBR=pkotwicz@chromium.org (themes)
TBR=atwilson@chromium.org (background)
TBR=rogerta@chromium.org (ui/sync)
BUG=455414
Review URL: https://codereview.chromium.org/1365443003
Cr-Commit-Position: refs/heads/master@{#351631}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's now the only kind of permission message :)
TBRing a bunch of trivial renames in c/b/ui.
TBR=sky@chromium.org
BUG=398257
Review URL: https://codereview.chromium.org/1309143003
Cr-Commit-Position: refs/heads/master@{#345913}
|
|
|
|
|
|
|
|
|
|
|
|
| |
and all the (unused) code that referenced it.
[This is part 5 of operation "remove the old permission message system".]
BUG=398257
Review URL: https://codereview.chromium.org/1213623006
Cr-Commit-Position: refs/heads/master@{#344495}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSockets use url::Origin to pass origin info between renderer and
browser. Currently, it cannot hold an origin with non-file scheme and
no port. Chrome extensions have been using such origins, so we need
to keep the channel to convey origin info work for such origins.
BUG=516971
R=sleevi,brettw
Committed: https://crrev.com/1ac9ec7bccd1b5178b18338b10149f36292f5fb6
Cr-Commit-Position: refs/heads/master@{#343895}
Review URL: https://codereview.chromium.org/1272113002
Cr-Commit-Position: refs/heads/master@{#344181}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #16 id:320001 of https://codereview.chromium.org/1272113002/ )
Reason for revert:
Broken build.
http://build.chromium.org/p/chromium.mac/builders/iOS_Device_%28ninja%29/builds/17899/steps/compile/logs/stdio
Original issue's description:
> Allow url::SchemeHostPort to hold non-file scheme without port
>
> WebSockets use url::Origin to pass origin info between renderer and
> browser. Currently, it cannot hold an origin with non-file scheme and
> no port. Chrome extensions have been using such origins, so we need
> to keep the channel to convey origin info work for such origins.
>
> BUG=516971
> R=sleevi,brettw
>
> Committed: https://crrev.com/1ac9ec7bccd1b5178b18338b10149f36292f5fb6
> Cr-Commit-Position: refs/heads/master@{#343895}
TBR=rsleevi@chromium.org,mkwst@chromium.org,brettw@chromium.org,tyoshino@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=516971
Review URL: https://codereview.chromium.org/1301563003
Cr-Commit-Position: refs/heads/master@{#343898}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebSockets use url::Origin to pass origin info between renderer and
browser. Currently, it cannot hold an origin with non-file scheme and
no port. Chrome extensions have been using such origins, so we need
to keep the channel to convey origin info work for such origins.
BUG=516971
R=sleevi,brettw
Review URL: https://codereview.chromium.org/1272113002
Cr-Commit-Position: refs/heads/master@{#343895}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switch all callers over to the new system (CoalescedPermissionMessages).
Also rename GetCoalescedPermissionMessages to GetPermissionMessages - it's the only way to get permission messages now.
[This is part 2 of operation "remove the old permission message system".]
TBRing trivial changes in ephemeral_app_launcher.cc and extension_install_dialog_view_browsertest.cc.
TBR=benwells@chromium.org
BUG=398257
Review URL: https://codereview.chromium.org/1218373003
Cr-Commit-Position: refs/heads/master@{#341734}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove all the *Legacy* methods, the old coalescing/suppression rules, and the code/field trial to switch between old and new system.
[This is part 1 of operation "remove the old permission message system".]
BUG=398257
Review URL: https://codereview.chromium.org/1179713006
Cr-Commit-Position: refs/heads/master@{#341503}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
generated bundle names.
At the moment the 3 modules that use extension API schemas, those in
extensions/common/api, chrome/common/extensions/api, and extensions/shell/api,
are generated with different C++ namespaces: "core_api", "api", and
"shell::api" respectively.
This is a pointless distinction to make since as far as JS is concerned they
must all go on the window.chrome object, therefore namespace conflicts are
impossible. It just ends up adding code noise.
The only problem it solves is that all bundle compiles are generated to the
same name, "GeneratedSchemas" and "GeneratedFunctionRegistry". This patch
solves that a different way, by adding a JSON schema compiler option to give
those generated classes a prefix such that they are "GeneratedSchemas",
"ChromeGeneratedSchemas", and "ShellGeneratedSchemas" respectively.
This lets us to a global substitution from "core_api" to just "api".
R=rockot@chromium.org, dpranke@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/1226353004
Cr-Commit-Position: refs/heads/master@{#340119}
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces it with base::StartsWith and the appropriate case flag. Since the existing version only ever did case-insensitive tests in ASCII, there should be no behavior change.
BUG=506255
TBR=jam
Review URL: https://codereview.chromium.org/1242023005
Cr-Commit-Position: refs/heads/master@{#339175}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1226673003
Cr-Commit-Position: refs/heads/master@{#337488}
|
|
|
|
|
|
|
|
|
| |
NOPRESUBMIT=true
(no presubmit due to removing base:: from a ScopedAllowIO)
Review URL: https://codereview.chromium.org/1172183002
Cr-Commit-Position: refs/heads/master@{#334108}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Up until recently the behavior has been to crash on canary and dev channels,
pick those up as regressions as per usual (e.g. we get a nice stack trace),
then not crash in beta or stable.
Recently those crashes have picked up, and while I work on a fix for that,
r327369 disabled all crashes, suppressing all crashes. This patch records all
suppressed crashes, something we perhaps should have been doing for a while.
BUG=471599
R=rdevlin.cronin@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/1114733002
Cr-Commit-Position: refs/heads/master@{#327624}
|
|
|
|
|
|
|
|
| |
BUG=chrome-os-partner:37102
Review URL: https://codereview.chromium.org/1085973002
Cr-Commit-Position: refs/heads/master@{#325525}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Update lots of tests to check that the old and new system match.
- In the process, fix two small bugs in the new system.
- Rename PermissionsData::GetPermissionMessageStrings and GetPermissionMessageDetailsStrings to "*Legacy*", to match the corresponding methods in PermissionMessageProvider.
BUG=398257
TBR=asargent
for a trivial rename in ephemeral_app_launcher.cc
Review URL: https://codereview.chromium.org/980353003
Cr-Commit-Position: refs/heads/master@{#321550}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PermissionMessageProvider:
- add GetPermissionMessageStrings which calls either the old or the new system, based on a field trial
- rename GetWarningMessages/GetWarningMessagesDetails to *Legacy*
- replace GetPermissionMessages by GetLegacyPermissionMessageIDs -> remove the old PermissionMessages type from the interface
Callers have *not* been updated to use the new GetPermissionMessageStrings yet.
TBRing trivial change in ephemeral_app_launcher.cc
TBR=asargent@chromium.org
BUG=398257
Review URL: https://codereview.chromium.org/1006453002
Cr-Commit-Position: refs/heads/master@{#320702}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a GetCoalescedPermissionMessages() method to
PermissionMessageProvider and all its subclasses, including
ChromePermissionMessageProvider. Also implemented the first set of rules
to achieve parity with the existing apps/extensions permission messages
system.
Also updated PermissionsData to have a GetCoalescedPermissionMessages()
function which returns the coalesced permission messages for an app
or extension, and updated the unit tests to check the test output for
both the legacy and new systems.
No callsites that display permission messages have been updated to use
the new system.
BUG=398257
Review URL: https://codereview.chromium.org/798463003
Cr-Commit-Position: refs/heads/master@{#317533}
|
|
|
|
|
|
|
|
|
|
|
| |
Nothing uses this API and the API is the only user of the privetd bindings.
BUG=458724
TEST=compiles, chromeos_unittests, app_shell_unittests
Review URL: https://codereview.chromium.org/925893003
Cr-Commit-Position: refs/heads/master@{#316698}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the D-Bus library to automatically reads the property
state at startup and monitor it for changes.
Wrap it in a chrome.shell API for manual testing. This will
be removed once bootstrap is wired into OOBE.
BUG=428848
TEST=app_shell_unittests, manual tests with app in the bug
Review URL: https://codereview.chromium.org/719713004
Cr-Commit-Position: refs/heads/master@{#314462}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/. I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".
This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*. Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects. Doing that will be more acceptable when the two sides live
in the same directory.
* chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
necessary since the trusted plugin isn't a separate DSO/DLL these
days.
* .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
no longer exists.
* module_ppapi.h: Added an #include guard.
BUG=239656
TEST=trybots
Review URL: https://codereview.chromium.org/876483002
Cr-Commit-Position: refs/heads/master@{#313759}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Extend PrivetDaemonClient to invoke the "Ping" D-Bus method
on org.chromium.privetd.Manager.
This is connected to the chrome.shell.gcd API for manual
testing, but that will be deleted soon in favor of talking to
privetd as part of Chrome OS OOBE. Manual tests require
adding user chronos to group privetd in /etc/groups until
https://code.google.com/p/brillo/issues/detail?id=3 lands.
BUG=428848
TEST=added chromeos_unittests PrivetDaemonClient.*
Review URL: https://codereview.chromium.org/869153005
Cr-Commit-Position: refs/heads/master@{#313298}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now ChromeExtensionsClient has the only real implementation of
this function, and it returns the icons for:
1) the extension itself (the top-level icons key in the manifest)
2) page/browser actions
3) theme images
This patch moves to having a default implementation in ExtensionsClient
of GetBrowserImagePaths which returns the paths for (1), leaving
(2) and (3) speficic to ChromeExtensionsClient.
We need to do this to enable the Unpacker class to move from chrome/ to
extensions/, because the unpacker does some validation checks on the
paths returned by GetBrowserImagePaths and has tests for that
validation we want to move out of chrome/ also.
BUG=447014
Review URL: https://codereview.chromium.org/840813005
Cr-Commit-Position: refs/heads/master@{#310537}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--app-shell-host-window-size.
The keyword "bounds" doesn't make sense because this switch is used to change only the size of the host window.
Similar CL had landed[1] for content_shell with --content-shell-host-window-size as a switch name.
[1] https://codereview.chromium.org/783203002/
Review URL: https://codereview.chromium.org/805203002
Cr-Commit-Position: refs/heads/master@{#308592}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide stubs for chrome.identity.removeCachedAuthToken() and chrome.identity.
onSignInChanged.
BUG=441976
TEST=added to app_shell_unittests
Review URL: https://codereview.chromium.org/804673002
Cr-Commit-Position: refs/heads/master@{#308421}
|
|
|
|
|
|
|
|
|
|
|
|
| |
_behavior_features.json. Arbitrarily use it to implement the allow-in-incognito
whitelist.
BUG=440194
R=rockot@chromium.org
Review URL: https://codereview.chromium.org/789383002
Cr-Commit-Position: refs/heads/master@{#308311}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new type, CoalescedPermissionMessage, which represents a
permission message made up of 0 or more permissions. Also started a
refactor to move IDs out of APIPermission::ID and PermissionMessage::ID
and into their own common class.
Added a new method GetPermissions() to ManifestPermission, which allows
manifest permissions to specify their own custom permissions (and hence
custom messages) for apps with that permission. Updated all 5 subclasses
(automation, bluetooth, sockets, UI overrides hanlder and the mock
manifest).
Also added another FilterHostPermissions() method to ExtensionsClient
that can create CoalescedPermissionMessages.
BUG=398257
Committed: https://crrev.com/45d827a6ba247ef55275c52ade2dfddbaeb87a9f
Cr-Commit-Position: refs/heads/master@{#307630}
Review URL: https://codereview.chromium.org/750353003
Cr-Commit-Position: refs/heads/master@{#307677}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#6 id:160001 of https://codereview.chromium.org/750353003/)
Reason for revert:
Static initializers in permission message utils
Original issue's description:
> Added CoalescedPermissionMessages to ManifestPermissions
>
> Added a new type, CoalescedPermissionMessage, which represents a
> permission message made up of 0 or more permissions. Also started a
> refactor to move IDs out of APIPermission::ID and PermissionMessage::ID
> and into their own common class.
>
> Added a new method GetPermissions() to ManifestPermission, which allows
> manifest permissions to specify their own custom permissions (and hence
> custom messages) for apps with that permission. Updated all 5 subclasses
> (automation, bluetooth, sockets, UI overrides hanlder and the mock
> manifest).
>
> Also added another FilterHostPermissions() method to ExtensionsClient
> that can create CoalescedPermissionMessages.
>
> BUG=398257
>
> Committed: https://crrev.com/45d827a6ba247ef55275c52ade2dfddbaeb87a9f
> Cr-Commit-Position: refs/heads/master@{#307630}
TBR=yoz@chromium.org,sashab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398257
Review URL: https://codereview.chromium.org/793633003
Cr-Commit-Position: refs/heads/master@{#307660}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a new type, CoalescedPermissionMessage, which represents a
permission message made up of 0 or more permissions. Also started a
refactor to move IDs out of APIPermission::ID and PermissionMessage::ID
and into their own common class.
Added a new method GetPermissions() to ManifestPermission, which allows
manifest permissions to specify their own custom permissions (and hence
custom messages) for apps with that permission. Updated all 5 subclasses
(automation, bluetooth, sockets, UI overrides hanlder and the mock
manifest).
Also added another FilterHostPermissions() method to ExtensionsClient
that can create CoalescedPermissionMessages.
BUG=398257
Review URL: https://codereview.chromium.org/750353003
Cr-Commit-Position: refs/heads/master@{#307630}
|
|
|
|
|
|
|
|
|
|
|
| |
No intended functionality change.
R=brettw@chromium.org
BUG=348474
Review URL: https://codereview.chromium.org/774283002
Cr-Commit-Position: refs/heads/master@{#306641}
|
|
|
|
|
|
|
|
|
|
| |
This API will not be implemented, so the bindings must be removed.
BUG=424650
Review URL: https://codereview.chromium.org/737863003
Cr-Commit-Position: refs/heads/master@{#304727}
|
|
|
|
|
|
|
|
|
|
| |
the first one.
BUG=432359
Review URL: https://codereview.chromium.org/727963004
Cr-Commit-Position: refs/heads/master@{#304500}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, extension_file_util::GetBrowserImagePaths
exists and provides universal logic for identifying
sensitive image paths within an extension: i.e. paths to
images which may need to be transcoded before being handed
to the browser to display in its privileged UI.
This list of images depends entirely on the extensions
embedder, so it makes sense to define it within
ExtensionsClient. That's what this CL does. It establishes
such an interface in ExtensionsClient, and moves the very
Chrome-specific logic out of
extension_file_util::GetBrowserImagePaths and into
ChromeExtensionsClient.
BUG=398671
R=scheib@chromium.org
TBR=shuchen@chromium.org,yoz@chromium.org for mechanical updates
Review URL: https://codereview.chromium.org/719403002
Cr-Commit-Position: refs/heads/master@{#304096}
|
|
|
|
|
|
|
|
|
|
|
|
| |
privetd is a Chrome OS local disovery and setup daemon. This connects the
shell.gcd app_shell API to the DBus methods to get setup status.
BUG=428853,428848
TEST=app_shell_unittests
Review URL: https://codereview.chromium.org/687823007
Cr-Commit-Position: refs/heads/master@{#303750}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It can download a CRX from the web store using an ID given at the
command line.
This wires up utility process support for app_shell and establishes
a base for factoring additional extensions utility IPCs out of
//chrome in the near future.
BUG=398671
TBR=asargent@chromium.org for cloned dependency on omaha_query_params
Review URL: https://codereview.chromium.org/693233003
Cr-Commit-Position: refs/heads/master@{#303055}
|
|
|
|
|
|
|
|
|
|
| |
An error in the invocation of the exec_script call made GN re-run every time you compiled. The reason is that the VERSION file referenced in the deps of the script invocation had the wrong path. Since the file didn't exist, Ninja would always run the build step.
Forking scripts to run a GN-time is very unfortunate and slows everything down. This should only be done in extreme circumstances. There is already a template to do the version scripts at build time, we just need to move the definition of VERSION_FULL from the build file to the .in file.
Review URL: https://codereview.chromium.org/704903002
Cr-Commit-Position: refs/heads/master@{#302972}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This initial implementation does nothing. Eventually it will talk to privet
and buffet to determine setup state and show progress.
BUG=428853
TEST=app_shell_unittests
Review URL: https://codereview.chromium.org/690093002
Cr-Commit-Position: refs/heads/master@{#302507}
|
|
|
|
|
|
|
|
| |
BUG=424650
Review URL: https://codereview.chromium.org/686983002
Cr-Commit-Position: refs/heads/master@{#302338}
|
|
|
|
|
|
|
|
|
|
| |
BUG=424333
R=jamescook@chromium.org, rockot@chromium.org
TEST=manually
Review URL: https://codereview.chromium.org/676043005
Cr-Commit-Position: refs/heads/master@{#301798}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly for testing. It takes a refresh token on the
command line and uses it to provide access tokens via the
chrome.identity.getAuthToken() API.
BUG=424653
TEST=app_shell_unittests ShellOAuth2TokenServiceTest and IdentityApiTest
Review URL: https://codereview.chromium.org/670473003
Cr-Commit-Position: refs/heads/master@{#301738}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/667153007
Cr-Commit-Position: refs/heads/master@{#301453}
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a stub for an identity-related API as an example.
BUG=424651
TEST=app_shell_unittests
Review URL: https://codereview.chromium.org/660333003
Cr-Commit-Position: refs/heads/master@{#300265}
|
|
|
|
|
|
|
|
| |
BUG=417463
Review URL: https://codereview.chromium.org/622343002
Cr-Commit-Position: refs/heads/master@{#298042}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was being done as a one-off in app_shell and replicated in Chrome.
Moved it to RegisterCommonManifestHandlers() where it belongs.
BUG=none
TEST=extensions_unittests, unit_tests
Review URL: https://codereview.chromium.org/586873003
Cr-Commit-Position: refs/heads/master@{#295842}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of Chrome-specific "constants."
These URLs can be overridden by extensions embedders now
and are no longer incorrectly classified as "constants."
BUG=398671
TBR=xiyuan@chromium.org,sky@chromium.org for various files with header updates
Review URL: https://codereview.chromium.org/575113002
Cr-Commit-Position: refs/heads/master@{#295523}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The chrome.app.window API has been moved to src/extensions, so app_shell
no longer needs its custom chrome.shell API to open windows.
* Remove the API implementation -- mostly a manual revert of https://codereview.chromium.org/254473011/
* Remove app_shell_resources.grd since there are no more app_shell resources
* Remove athena's support for ShellAppWindow
* Fix example apps to remove the chrome.shell workaround.
No presubmit because it has a false-positive warning about the enum rename in extension_function_histogram_value.h
No try because no presubmit doesn't seem to work by itself.
BUG=413164
TEST=extensions_unittests, app_shell_unittests, app_shell_browsertests
TBR=isherman@chromium.org for deprecating an extension function histogram
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/571643003
Cr-Commit-Position: refs/heads/master@{#294852}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webrequest api, to extensions.
This cl resolve the dependencies of ExtensionsWarningSet of chrome strings:
- move the declarations of IDS_EXTENSION_WARNINGS_XXX to extensions_strings.grd;
- replace the usage of "IDS_PRODUCT_NAME" by creating GetProductName() function in ExtensionsClient and its subclasses.
BUG=352293
Review URL: https://codereview.chromium.org/503033002
Cr-Commit-Position: refs/heads/master@{#292378}
|