summaryrefslogtreecommitdiffstats
path: root/win8
Commit message (Collapse)AuthorAgeFilesLines
* Remove win8/metro_driverscottmg2016-03-1848-7327/+0
| | | | | | | | | | | Dead code now. R=ananta@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1815463002 Cr-Commit-Position: refs/heads/master@{#382101}
* Remove delegate_executescottmg2016-03-1819-1620/+0
| | | | | | | | | | | | Dead code now. TBR=sky@chromium.org R=gab@chromium.org, grt@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1811853005 Cr-Commit-Position: refs/heads/master@{#382019}
* Fix missing VisualElementsManifest.xmlscottmg2016-03-138-28/+29
| | | | | | | | | | | | | Move out of metro_driver too, as it doesn't have anything to do with Metro in its current incarnation. TBR=brettw@chromium.org R=gab@chromium.org, grt@chromium.org, dpranke@chromium.org BUG=593411 Review URL: https://codereview.chromium.org/1790723002 Cr-Commit-Position: refs/heads/master@{#380886}
* Convert Pass()→std::move() on Windowsdcheng2016-03-021-5/+5
| | | | | | | | | | | | | Also cleaned up a few stragglers from grepping the source: it's unclear if these are just building with weird defines, don't build at all, only build on obscure platforms, or something else… either way, Pass() itself will be removed shortly after this. BUG=557422 Review URL: https://codereview.chromium.org/1752233002 Cr-Commit-Position: refs/heads/master@{#378872}
* Cleanup DelegateExecute and other Metro registration.gab2016-01-221-29/+3
| | | | | | | | | | | | | | | | | + stop writing launch_mode to the registry now that we no longer read it after https://codereview.chromium.org/1581473002. + clean launch_mode from existing installs. + fix BrowserDistribution::GetRegistryPath() to not return something for binary distributions. + bump Active Setup major version to trigger per-user registry cleanup BUG=558054, 577751 Review URL: https://codereview.chromium.org/1587123005 Cr-Commit-Position: refs/heads/master@{#370989}
* Reland of move remote tree host and some related input and metro_driver code ↵samli2016-01-2021-5250/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1602403002/ ) Reason for revert: Didn't help, looks like the slave is out of disk space. Original issue's description: > Revert of Remove remote tree host and some related input and metro_driver code (patchset #5 id:80001 of https://codereview.chromium.org/1586843002/ ) > > Reason for revert: > Suspecting that this is breaking the Webkit Win (dbg) builder. > > First failed build: > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/88362 > > Original issue's description: > > Remove remote tree host and some related input and metro_driver code > > > > Part of continued stripping out of Metro/Win8/Immersive mode. > > > > BUG=558054 > > > > Committed: https://crrev.com/5cc04f70e424020d8afe49bdc4c1c76683f0ea7b > > Cr-Commit-Position: refs/heads/master@{#370068} > > TBR=sky@chromium.org,thestig@chromium.org,shuchen@chromium.org,ananta@chromium.org,dpranke@chromium.org,scottmg@chromium.org > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > BUG=558054 > > Committed: https://crrev.com/0e3a9fd80a26f1fce889200d330d79e64d7a2586 > Cr-Commit-Position: refs/heads/master@{#370290} TBR=ananta@chromium.org,dpranke@chromium.org,scottmg@chromium.org,shuchen@chromium.org,sky@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=558054 Review URL: https://codereview.chromium.org/1605253002 Cr-Commit-Position: refs/heads/master@{#370300}
* Revert of Remove remote tree host and some related input and metro_driver ↵samli2016-01-2021-2/+5250
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | code (patchset #5 id:80001 of https://codereview.chromium.org/1586843002/ ) Reason for revert: Suspecting that this is breaking the Webkit Win (dbg) builder. First failed build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/88362 Original issue's description: > Remove remote tree host and some related input and metro_driver code > > Part of continued stripping out of Metro/Win8/Immersive mode. > > BUG=558054 > > Committed: https://crrev.com/5cc04f70e424020d8afe49bdc4c1c76683f0ea7b > Cr-Commit-Position: refs/heads/master@{#370068} TBR=sky@chromium.org,thestig@chromium.org,shuchen@chromium.org,ananta@chromium.org,dpranke@chromium.org,scottmg@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=558054 Review URL: https://codereview.chromium.org/1602403002 Cr-Commit-Position: refs/heads/master@{#370290}
* Remove unused function after https://codereview.chromium.org/1586843002scottmg2016-01-191-38/+0
| | | | | | | | | | | | | Found by clang: ..\..\win8\delegate_execute\command_execute_impl.cc(69,6) : error: unused function 'LaunchChromeBrowserProcess' [-Werror,-Wunused-function] R=thakis@chromium.org TBR=ananta@chromium.org BUG=558054,82385 Review URL: https://codereview.chromium.org/1604693002 Cr-Commit-Position: refs/heads/master@{#370074}
* Remove remote tree host and some related input and metro_driver codescottmg2016-01-1921-5250/+2
| | | | | | | | | | Part of continued stripping out of Metro/Win8/Immersive mode. BUG=558054 Review URL: https://codereview.chromium.org/1586843002 Cr-Commit-Position: refs/heads/master@{#370068}
* Remove base/win/metro.{cc|h} and some associated codescottmg2016-01-123-23/+1
| | | | | | | | | | | | | | | | | | | | The goal was to start by removing base/win/metro.{cc|h}, but this ended up touching a number of places. So, also removed are: chrome/browser/metro_utils/ chrome/browser/ui/apps/apps_metro_handler_win.{cc|h} chrome/browser/ui/metro_pin_tab_helper_win.{cc|h} chrome/browser/ui/views/frame/browser_frame_ashwin.{cc|h} In order for the CL to not get even larger, there are some added TODOs pointing at the associated bug where calls to the above were removed, but the surrounding code is not yet simplified. BUG=558054 Review URL: https://codereview.chromium.org/1581473002 Cr-Commit-Position: refs/heads/master@{#368971}
* Use .rc strings in fewer places for installer util.brettw2015-12-292-3/+3
| | | | | | | | | | The resource strings are needed only for the setup app and unit tests. Previously they were also linked into Chrome. This clarifies the usage and renames the targets to force you to pick (previously the naming encouraged you to link to the strings, which is probably not correct for most cases. Review URL: https://codereview.chromium.org/1545803002 Cr-Commit-Position: refs/heads/master@{#367057}
* Split GN installer_util into one that has no strings.brettw2015-12-222-2/+2
| | | | | | | | | | | | After a lot of study, the GYP build of chrome.exe is smaller partially because it doesn't include all of these generated strings. The strings are not needed by chrome.exe, but there is no sub-part of chrome/installer/util that can be factored such that the part that chrome.exe uses does not depend on the strings. This patch makes two targets, one for if you want the strings, and one for if you don't. This is rather precarious so I named the non-string-including target in a very detailed way. The result is the final link matches GYP in this respect, and saves about 200KB on chrome.exe TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1534903002 Cr-Commit-Position: refs/heads/master@{#366618}
* Switch to standard integer types in win8/.avi2015-12-2130-104/+135
| | | | | | | | | BUG=138542 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/1540973003 Cr-Commit-Position: refs/heads/master@{#366452}
* Make metro_driver_unittests build with clang/win.thakis2015-12-111-9/+9
| | | | | | | | | | | | | | | | | Explicit specializations must not have a storage class. Since the whole thing is in an unnamed namespace anyway, drop it on the template declaration too. ..\..\win8\metro_driver\winrt_utils_unittest.cc(19,16) : error: explicit specialization cannot have a storage class [-W error] static HRESULT CreateProperty<const wchar_t*>( ~~~~~~~ ^ BUG=82385 Review URL: https://codereview.chromium.org/1521473002 Cr-Commit-Position: refs/heads/master@{#364543}
* clang/win: Let remaining chromium_code targets build with -Wextra.thakis2015-12-101-3/+1
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/1507413003/ and lets all translation units in a release build build if -Wextra is enabled for chromium_code targets. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 Review URL: https://codereview.chromium.org/1513043002 Cr-Commit-Position: refs/heads/master@{#364425}
* clang/win: Let some chromium_code targets build with -Wextra.thakis2015-12-101-5/+5
| | | | | | | | | | | | | | | | | | | To make warning flags between Windows and non-Windows clang consistent, I'd like to build chromium_code targets with -Wextra enabled. This fixes -Wextra warnings in about 14k of 31k build steps. Most of the warnings were about signed/unsigned mismatches; some were about "const"s that had no effect. (This CL does not contain the change to actually turn on -Wextra, only cleanups.) BUG=567877 TBR=content/common/sandbox Review URL: https://codereview.chromium.org/1507413003 Cr-Commit-Position: refs/heads/master@{#364232}
* Fix chrome-branded component buildspmonette2015-12-081-0/+1
| | | | | | | | | | With is_chrome_branded = true and is_component_build = true, a linker error (unresolved external symbol) was generated for kForceFieldTrials in targets delegate_execute and chrome_watcher. Review URL: https://codereview.chromium.org/1507093002 Cr-Commit-Position: refs/heads/master@{#363790}
* Remove content_common from delegate_executebrettw2015-11-241-1/+0
| | | | | | | | This is not used and entirely dead-code-stripped by the linker (sadly this change doesn't make the binary any smaller). Review URL: https://codereview.chromium.org/1466423003 Cr-Commit-Position: refs/heads/master@{#361398}
* Add metro driver and delegate_execute to GN build.brettw2015-11-238-21/+271
| | | | | | | | | | This also makes //win8/* pass "gn check". BUG=512864,512869 Review URL: https://codereview.chromium.org/1464263003 Cr-Commit-Position: refs/heads/master@{#361211}
* Run gn --format over all .gn filesagrieve2015-11-201-2/+2
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* Fix small tile icon disappearing on Win10 10586scottmg2015-11-126-19/+10
| | | | | | | | | | | | | | | | | | | My best guess is that TH2 breaks the Metro path for VisualManifest for small icons (which is what we were using). Switching to the other (newer?) format seems to work. I'm not sure if this means that the Metro tile on maybe plain Win8 will be broken though. Any thoughts? Also, updated to new "flat" icons for the tiles (they're already in the icon resources, but we missed the tiles in the previous update I think). R=grt@chromium.org BUG=554439, 517654 Review URL: https://codereview.chromium.org/1441463002 Cr-Commit-Position: refs/heads/master@{#359345}
* gfx: Make conversions from gfx::Point to PointF explicit.danakj2015-11-021-3/+2
| | | | | | | | | | R=sky@chromium.org, vmpstr BUG=342848 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1372253002 Cr-Commit-Position: refs/heads/master@{#357460}
* Unify logic for "does chrome support metro on this Windows version".gab2015-11-021-2/+3
| | | | | | | | | | | | | Figured we'd want to unify places we have logic for this after http://crrev.com/356988. Also clarified check for |relaunch_mode| in upgrade_util_win based on the CL it was introduced in (http://crrev.com/292464). BUG=548965 Review URL: https://codereview.chromium.org/1427123002 Cr-Commit-Position: refs/heads/master@{#357363}
* Remove base::MessageLoop::{Quit,QuitClosure} functionski.stfu2015-10-232-2/+2
| | | | | | | | | | | | | This patch removes aliases for base::MessageLoop::QuitWhenIdle & base::MessageLoop::QuitWhenIdleClosure, and includes minor formatting changes made by using git cl-format. BUG=131220 TEST= R=danakj@chromium.org,brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1390513002 Cr-Commit-Position: refs/heads/master@{#355763}
* Set modifier flags for Caps, OS, Scroll and Num Lock on X11 and Windows.dtapuska2015-10-202-4/+5
| | | | | | | | | | Adjust the bit translation functions to ensure the values are set correctly on the WebInputEvent. Add support for querying the values from the native OS on Windows. Collapse duplicated code in the Windows event builder to query active key states. BUG=265458 Review URL: https://codereview.chromium.org/1372253005 Cr-Commit-Position: refs/heads/master@{#355170}
* Prune metro bits from the ash testsrobertshield2015-10-054-159/+0
| | | | | | | | BUG=332504 Review URL: https://codereview.chromium.org/1379683002 Cr-Commit-Position: refs/heads/master@{#352388}
* Remove all Windows Window Scoped Trackers and Associated Instrumentationrobliao2015-09-291-1/+0
| | | | | | | | | | | | The jank dashboard shows that there is nothing actionable remaining to do here. The sampling profiler should be able to supersede any manual tracking should we need to investigate future jank. BUG=440919 Review URL: https://codereview.chromium.org/1370993003 Cr-Commit-Position: refs/heads/master@{#351254}
* Make GetCommandExecuteImplClsid return the CLSID as a string directly.gab2015-09-021-2/+2
| | | | | | | | BUG=Unjustified single out-param. Review URL: https://codereview.chromium.org/1321143002 Cr-Commit-Position: refs/heads/master@{#346915}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-1/+2
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Remove remaining legacy SplitString calls.brettw2015-08-121-2/+2
| | | | | | | | TBR=zelidrag@chromium.org (chromeos) Review URL: https://codereview.chromium.org/1284833004 Cr-Commit-Position: refs/heads/master@{#342983}
* clang/win: Build chromium_code with -Wunused-functionNico Weber2015-08-081-0/+2
| | | | | | | | | BUG=505316 R=dalecurtis@chromium.org, dcheng@chromium.org, robertshield@chromium.org Review URL: https://codereview.chromium.org/1261953003. Cr-Commit-Position: refs/heads/master@{#342535}
* clang/win: Fix most -Wunused-function warnings in Chromium code.thakis2015-07-281-14/+0
| | | | | | | | | | | No intended behavior change. BUG=505316 TBR=armansito Review URL: https://codereview.chromium.org/1255073002 Cr-Commit-Position: refs/heads/master@{#340761}
* PlatformThreadHandle: remove public id() interfacetoyoshim2015-07-241-1/+1
| | | | | | | | | | | | | Remove PlatformThreadHandle.id() interface. Also remove id_ member that is not needed any more. BUG=468793 TEST=./out/Debug/base_unittests TEST=git cl try Review URL: https://codereview.chromium.org/1207823004 Cr-Commit-Position: refs/heads/master@{#340242}
* Disable metro unit tests on Windows 10.wfh2015-07-221-5/+2
| | | | | | | | | | | | Move decision on whether to enable metro mode to ui/gfx/win. Metro mode is disabled already on Windows 10, so these tests were just failing. BUG=508754,470227 TEST=unit_tests.exe Review URL: https://codereview.chromium.org/1246233002 Cr-Commit-Position: refs/heads/master@{#339981}
* Remove CaseInsensitiveCompare from string_util.hbrettw2015-07-141-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | There were a number of callers in net using this for HTTP headers. I think these callers actually just need ASCII case-insensitive comparisons so these were changed. The omnibox code used this functor. I added a new omnibox-specific one which does not have the locale issues of the old string_util one, but which still has the UTF-16 and combining accent issues (described in great detail in the comment for this). The Windows installer code can't depend on ICU so it calls the Win32 function to do case-insensitive comparisons. This should match the system comparison for registry keys better anyway. I also changed a caller of StartsWith to use this version. I wrote this StartsWith call using ToLower in a previous patch, but it turns out that the lengths of case-mapped strings do change in practice, making the offset computations of the suyrrounding code incorrect. This new version will be like the old version (will miss some cases of case-insensitive equality) but will handle 0x80-0xFF properly. BUG=24917 Review URL: https://codereview.chromium.org/1230583014 Cr-Commit-Position: refs/heads/master@{#338624}
* Fix remaining warnings for -Wmissing-braces and enable on win clang.dcheng2015-07-081-1/+1
| | | | | | | | | | | | Missing braces have been located and restored to their rightful positions. BUG=505297 TBR=aboxhall,ananta,atwilson,hajimehoshi,jamiewalch,vitalybuka Review URL: https://codereview.chromium.org/1216413002 Cr-Commit-Position: refs/heads/master@{#337781}
* Fix "extra qualification on member [-Wmicrosoft]" warnings.thakis2015-07-071-3/+2
| | | | | | | | | | No behavior change. BUG=505296 Review URL: https://codereview.chromium.org/1226653002 Cr-Commit-Position: refs/heads/master@{#337640}
* Replace remaining Tokenize calls to SplitStringbrettw2015-07-062-12/+9
| | | | | | | | | | | | | | SplitString is now more general and does the job of Tokenize with specific parameters. The biggest change is in time_util.cc where the old return pattern better matched how the code was structured. With the new style the conditionals are more nested. Some simple cases were changed to StringPieces when copies were not required. BUG=506920, 506255 Review URL: https://codereview.chromium.org/1219263002 Cr-Commit-Position: refs/heads/master@{#337520}
* clang/win: Fix warnings to prepare for building without -Wno-reorder.sammc2015-07-024-7/+7
| | | | | | | | | | | | | This changes constructor initializer list ordering to match field declaration ordering, except for gtest and breakpad, where the warning is disabled. BUG=505304 NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1210013007 Cr-Commit-Position: refs/heads/master@{#337152}
* Migrate callers of message_loop_proxy() to task_runner()skyostil2015-06-171-1/+1
| | | | | | | | | | | | | Migrate callers of {MessageLoop,Thread}::message_loop_proxy() to {MessageLoop,Thread}::task_runner(). Since the types at the call sites have already been updated, this is just a bulk rename. BUG=465354 TBR=armansito@chromium.org Review URL: https://codereview.chromium.org/1179163002 Cr-Commit-Position: refs/heads/master@{#334840}
* Remove remaining use of the deprecated MessageLoopProxyskyostil2015-06-123-66/+55
| | | | | | | | | | | | | This patch removes the remaining usage of MessageLoopProxy outside base/. Note that there are still some call sites for Thread::message_loop_proxy() and MessageLoop::message_loop_proxy() which will be cleaned up separately. BUG=465354 Review URL: https://codereview.chromium.org/1169923009 Cr-Commit-Position: refs/heads/master@{#334198}
* Replace more ObserverList with base::ObserverList.brettw2015-06-031-1/+1
| | | | | | | | | | | | This is everything but the chrome directory CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=zelidrag@chromium.org (chromeos) TBR=keybuk@chromium.org (device/bluetooth) Review URL: https://codereview.chromium.org/1162943002 Cr-Commit-Position: refs/heads/master@{#332626}
* Remove Unactionable or Low Jank USER32 Instrumentationrobliao2015-06-021-4/+0
| | | | | | | | | | USER32 calls generally do not have an SLA on returning promptly. They do however, generally need to be called on the thread that created the hwnd. There's not much we can do with these calls. BUG=470226 Review URL: https://codereview.chromium.org/1163863003 Cr-Commit-Position: refs/heads/master@{#332322}
* No longer build/use google_update on non-Chrome builds.grt2015-05-273-1/+8
| | | | | | | | | | | | | | Google Update integration is not supported on Chromium builds. Also entirely remove the dependency on google_update from remoting/host/setup and win8/metro_driver, neither of which used it. BUG=none Review URL: https://codereview.chromium.org/1136473005 Cr-Commit-Position: refs/heads/master@{#331659}
* Send a Blur notification to the renderer if we receive a mouse exit for a ↵ananta2015-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | window outside a popup. Blink maintains state for popups whether they are hidden shown etc. So when a popup is shown and an action causes the popup to be hidden then blink changes the state to hidden. If an action causes the popup to be closed on the browser without notifying blink that the popup is going away due to focus being lost on the parent view, then blink assumes that the popup is still visible. As a result clicking again on a select box would just hide the popup as blink thinks the popup is visible. This bug is only triggered in corner cases like ASH where you have one root window parenting everything else. On regular desktop environments clicking outside the browser window while the popup is open would cause activation changes to occur which would ensure that the Blur notification goes through to the browser. The other change is a simple fix in delegate_execute which caused it to crash in debug mode on a multi dll build. Crash occurred because we were looking for version information in base.dll while launching the crash server. BUG=482937 Review URL: https://codereview.chromium.org/1136143005 Cr-Commit-Position: refs/heads/master@{#329563}
* win: Fix remaining style plugin warnings in win8/.thakis2015-05-044-36/+39
| | | | | | | | | | Also do a few minor style cleanups. BUG=467287 Review URL: https://codereview.chromium.org/1117413003 Cr-Commit-Position: refs/heads/master@{#328123}
* Address review comments from https://codereview.chromium.org/1120203004/thakis2015-05-021-1/+1
| | | | | | | | | | | | | | | | | Fixes these two warnings that that patch accidentally added: ..\..\win8/viewer/metro_viewer_process_host.h(194,29) : warning(clang): [chromium-style] Overriding method must be marked with 'override' or 'final'. ..\..\net\proxy\dhcp_proxy_script_adapter_fetcher_win_unittest.cc(85,26) : warning(clang): [chromium-style] Overriding method must be marked with 'override' or 'final'. BUG=467287 TBR=rsleevi@chromium.org Review URL: https://codereview.chromium.org/1120693004 Cr-Commit-Position: refs/heads/master@{#328052}
* win: Ref-counted classes should have non-public destructors.thakis2015-05-022-0/+5
| | | | | | | | | BUG=123295,467287 TBR=avi,rsleevi,kbr,grt Review URL: https://codereview.chromium.org/1120203004 Cr-Commit-Position: refs/heads/master@{#328040}
* Apply automated fixits for Chrome clang plugin to win8.dcheng2015-04-297-196/+177
| | | | | | | | | | | Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=ananta@chromium.org Review URL: https://codereview.chromium.org/1117743002 Cr-Commit-Position: refs/heads/master@{#327588}
* simplify brandinggburanov2015-04-251-11/+1
| | | | | | | | | | | | | Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Review URL: https://codereview.chromium.org/1106503003 Cr-Commit-Position: refs/heads/master@{#326963}
generated by cgit v1.1 at 2024-04-28 22:19:04 +0000